mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 64733: Fixed conversion warnings in tests.
Date Fri, 05 Jan 2018 22:50:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64733/#review194914
-----------------------------------------------------------


Ship it!




Ship It!

- Joseph Wu


On Jan. 5, 2018, 1:54 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64733/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2018, 1:54 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Jie Yu, Joseph Wu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Stringified a `size_t` for `http::Request.headers` value.
> 
> The types in `metrics_tests.cpp` were defined as `double`, and so should
> be compared with `EXPECT_DOUBLE_EQ`, not `EXPECT_FLOAT_EQ`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/http_tests.cpp 9daac715f0242921b7f9f5c20b3eb27f1be802d4

>   3rdparty/libprocess/src/tests/metrics_tests.cpp bb7c9e37e5576f5b2e3ecc1a215e1edac758b254

> 
> 
> Diff: https://reviews.apache.org/r/64733/diff/2/
> 
> 
> Testing
> -------
> 
> These are in libprocess.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message