mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <>
Subject Re: Review Request 63860: Windows: Mapped the Docker network info types.
Date Fri, 05 Jan 2018 22:25:15 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Jan. 5, 2018, 10:25 p.m.)

Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, Jie Yu,
John Kordich, Joseph Wu, and Michael Park.


Updated with Jie's feedback

Bugs: MESOS-7342

Repository: mesos


The Network enum in DockerInfo is specific to Linux containers. `HOST`
doesn't exist on Windows and `BRIDGE` is `NAT` on Windows. The current
default docker network setting was always `HOST`, which broke the
Windows docker executor. Now, if a specific network isn't given, the
network mode will default to `HOST` on Linux agents and `NAT` on Windows
agents. Also, `BRIDGE` mode will be translated to `NAT` on Windows.

Diffs (updated)

  src/docker/docker.cpp 722a54ad113fc4e2bb22a8f08e307ab38d5fbfed 




See for test results.


Akash Gupta

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message