mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Coffler <j...@taltos.com>
Subject Re: Review Request 64962: Windows: Explicitly state source and destination path for extract.
Date Fri, 05 Jan 2018 22:01:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64962/#review194907
-----------------------------------------------------------




src/launcher/fetcher.cpp
Line 101 (original), 103 (patched)
<https://reviews.apache.org/r/64962/#comment273990>

    I got the syntax straight from the help page from `help Expand-Archive`. But I guess if
you don't know the parameters and don't want to get help, this will clarify.


- Jeff Coffler


On Jan. 5, 2018, 9:50 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64962/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2018, 9:50 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Jeff Coffler, Joseph Wu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Makes it more clear that it is in the correct order.
> 
> 
> Diffs
> -----
> 
>   src/launcher/fetcher.cpp e2372a1b52d19937a62bd3fd5fe594c9e347e4a8 
> 
> 
> Diff: https://reviews.apache.org/r/64962/diff/1/
> 
> 
> Testing
> -------
> 
> ctest -V on Windows (all passed)
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message