mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 64732: Fixed conversion warnings in tests.
Date Fri, 05 Jan 2018 21:53:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64732/
-----------------------------------------------------------

(Updated Jan. 5, 2018, 1:53 p.m.)


Review request for mesos, Greg Mann, Jie Yu, Joseph Wu, and Michael Park.


Changes
-------

Rebased.


Repository: mesos


Description
-------

The signature of `flags.load` takes an `int`, but
`arraySize` (correctly) returns a `size_t`. We don't want to change
`flags.load` to take a `size_t` because its signature is `int argc,
char** argv`, and so we may be sending it `int` in other places.

As all the test arrays are statically sized, we know that we're not
overflowing an `int`, so it is safe to just `static_cast<int>` here.


Diffs (updated)
-----

  3rdparty/stout/tests/flags_tests.cpp 60ed8ebdd7b491e0d9469985f6263aad64b44c51 
  3rdparty/stout/tests/subcommand_tests.cpp 54d70c99083fc1de16c732917e1faf1ee59ef646 


Diff: https://reviews.apache.org/r/64732/diff/2/

Changes: https://reviews.apache.org/r/64732/diff/1-2/


Testing
-------

These are in stout.


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message