mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 64729: Made `Duration::operator*` accept `int` and `size_t`.
Date Fri, 05 Jan 2018 21:53:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64729/
-----------------------------------------------------------

(Updated Jan. 5, 2018, 1:53 p.m.)


Review request for mesos, Greg Mann, Jie Yu, Joseph Wu, and Michael Park.


Changes
-------

Rebased.


Repository: mesos


Description (updated)
-------

Without this change, every use of `Duration * 2` throws a conversion
warning because we multiple `Duration` by `int` and `size_t` without
casting to `double` (the type accepted by the actual implementation of
`operator*`).


Diffs (updated)
-----

  3rdparty/stout/include/stout/duration.hpp d10b6a4d4d1a0096334c30fdec725ecc55c9f0ea 


Diff: https://reviews.apache.org/r/64729/diff/2/

Changes: https://reviews.apache.org/r/64729/diff/1-2/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message