mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 64973: Renamed VolumeProfileAdaptor to DiskProfileAdaptor (continued).
Date Fri, 05 Jan 2018 17:11:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64973/#review194877
-----------------------------------------------------------




src/Makefile.am
Line 1477 (original), 1477 (patched)
<https://reviews.apache.org/r/64973/#comment273952>

    ditto. alignment for the `` in the end


- Jie Yu


On Jan. 5, 2018, 10:46 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64973/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2018, 10:46 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This renames the contents of the files rather than just the filenames.
> 
> This commit will be squashed into the previous review before commit.
> 
> 
> Diffs
> -----
> 
>   docs/csi.md d268df19c35720937323995b60f51601f7866342 
>   include/mesos/mesos.proto c677a8be07d0ef209d42622ae32056d36e55ff78 
>   include/mesos/module/disk_profile.hpp bb95b32a18aa3ca316dd806c99b428bddfaba423 
>   include/mesos/resource_provider/storage/disk_profile.hpp 7141a14a0cef4757717316a6fc6b92ecf40f20af

>   include/mesos/v1/mesos.proto da7b4587891c47c02345209e0fdca60585a36fdc 
>   src/Makefile.am 30cd4d426e797e4c8ee556d1bc3de99830a5fe41 
>   src/module/manager.cpp f038f05ced9a4f967c67b48487f53a39ff4e9e89 
>   src/resource_provider/storage/disk_profile.cpp 336220d241458b3fc4cd356354677c89b442440f

>   src/resource_provider/storage/disk_profile.proto c0628ecd451312f521680cacad854ab04dcd4c90

>   src/resource_provider/storage/disk_profile_utils.hpp 46afbd3a0eba8e1a0635ba9551843f2dce4d6def

>   src/resource_provider/storage/disk_profile_utils.cpp 3d04558459ed5f970533c4d02a57cb07a5984bbb

>   src/resource_provider/storage/provider.cpp a9f007a061691ea3c6c61fc965cf3a3e764a7275

>   src/resource_provider/storage/uri_disk_profile.hpp a58758cd943bc7dff4dd096689e5a78a70f9d2ce

>   src/resource_provider/storage/uri_disk_profile.cpp 4431ad11207d08f86f919042ef957b916c55ddfa

>   src/slave/flags.hpp 1cf5272301b54c73a4bdee4ae1dda7f7d75d55ce 
>   src/slave/flags.cpp 48b882152b89cfd3f942382a28b79b7f26aeeefd 
>   src/slave/slave.hpp b5eec3352e950371097b74a7f0516e474a4e2a0c 
>   src/slave/slave.cpp cfb675df677e7a0d476b8d5a586afc2f197ab810 
>   src/tests/disk_profile_tests.cpp 6ed81c90d8769889cfc4f91f9b378acd9c42c038 
>   src/tests/storage_local_resource_provider_tests.cpp b522b406205ab4a8cb430bedd18ec00c9f437e8a

> 
> 
> Diff: https://reviews.apache.org/r/64973/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message