mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 64980: Updated health check doc with 3xx redirects.
Date Fri, 05 Jan 2018 16:12:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64980/#review194870
-----------------------------------------------------------


Ship it!





docs/health-checks.md
Lines 389-390 (original), 392-393 (patched)
<https://reviews.apache.org/r/64980/#comment273947>

    This may sound confusing but after discussing with Alex, I understood it indeed is exactly
accurate.
    
    So we do actually not expect CURL with activate redirect-follow to ever come back with
a 3XX as it should follow instead and return what it gets then. But if CURL now decided it
followed enough redirects, maybe it does actually come back with a 3XX even though it should
follow instead. SUCH case is treated as a success and that is exactly what this says :)


- Till Toenshoff


On Jan. 5, 2018, 4 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64980/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2018, 4 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/health-checks.md b9b6327dea8c70dbc4aab204487a088f76c79479 
> 
> 
> Diff: https://reviews.apache.org/r/64980/diff/2/
> 
> 
> Testing
> -------
> 
> Rendered in MacDown.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message