mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 64970: Replace ad hoc venv under support/ with tox.
Date Fri, 05 Jan 2018 12:38:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64970/#review194853
-----------------------------------------------------------



I agree with Kevin, hhaving tox managing our virtualenvs rather than doing it manually is
a good idea but the cost of having a new tool that Mesos contributors need to install for
the Python linting process seems too high. This is reinforced by the fact that the JS linter
will still require a manually managed virtualenv in `/support`, this patch will thus add a
new virtualenv instead of replacing/removing an existent one.


support/mesos-style.py
Line 150 (original), 150 (patched)
<https://reviews.apache.org/r/64970/#comment273919>

    `mesos/support/tox.ini` does not exist and is not added in this patch, is that normal?


- Armand Grillet


On Jan. 5, 2018, 8:26 a.m., Eric Chung wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64970/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2018, 8:26 a.m.)
> 
> 
> Review request for mesos, Armand Grillet and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replace ad hoc venv under support/ with tox.
> 
> This patch changes the ad hoc .virtualenv created under support/ with tox, a tool that
manages virtualenvs with a declaritive config file. The cool thing about it is that you can
actually have multiple tox.ini files distributed in different python source trees, so you
don't really have to install all of the depedencies into a single virtualenv; all you need
to do is to run `tox -e <env> <command>` at the root of the source tree.
> 
> 
> Diffs
> -----
> 
>   support/.gitignore a21a0f95b9113eae2881d2e346821c86761bb2bc 
>   support/mesos-style.py 1b34ea2d9afa8f17b545841cea7a6853a6e18144 
> 
> 
> Diff: https://reviews.apache.org/r/64970/diff/1/
> 
> 
> Testing
> -------
> 
> 1. intentionally create a lint error, such as extra spaces before a parens in a python
file
> 2. run the pre-commit hook and see tox in action
> 
> 
> Thanks,
> 
> Eric Chung
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message