mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 64932: Added example framework converting disk resources.
Date Fri, 05 Jan 2018 12:38:14 GMT


> On Jan. 5, 2018, 6:01 a.m., Greg Mann wrote:
> > src/examples/test_csi_user_framework.cpp
> > Lines 282 (patched)
> > <https://reviews.apache.org/r/64932/diff/1/?file=1930012#file1930012line282>
> >
> >     Is it not possible that a single resource provider can offer both reserved and
unreserved resources? Even if the current SLRP provides this guarantee, can we be sure that
all RPs will honor it?

This guarantee only works under a very specific setup, and we should be able to deal with
a much broader set of resources.

I removed this block here, but instead added an additional check to above filter loop.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64932/#review194830
-----------------------------------------------------------


On Jan. 5, 2018, 1:37 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64932/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2018, 1:37 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch introduces an example HTTP framework which transforms
> 'RAW' disk resources from resource providers into 'MOUNT' volumes and
> subsequently unreserves them.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 30cd4d426e797e4c8ee556d1bc3de99830a5fe41 
>   src/examples/CMakeLists.txt d4f1af4f072efdc68fa0b722f42b1d8aa1779b6e 
>   src/examples/test_csi_user_framework.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64932/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message