mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Review Request 64972: Renamed VolumeProfileAdaptor to DiskProfileAdaptor.
Date Fri, 05 Jan 2018 10:46:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64972/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Repository: mesos


Description
-------

"Disk Profile" is more accurate than "Volume Profile" when describing
the set of parameters passed into a Storage Resource Provider while
creating disk resources.  A disk resource is not necessarily a "Volume"
but will always be a disk.

This commit only renames the affected files.


Diffs
-----

  include/mesos/module/volume_profile.hpp  
  include/mesos/resource_provider/storage/volume_profile.hpp  
  src/resource_provider/storage/uri_volume_profile.hpp  
  src/resource_provider/storage/uri_volume_profile.cpp  
  src/resource_provider/storage/volume_profile.cpp  
  src/resource_provider/storage/volume_profile.proto  
  src/resource_provider/storage/volume_profile_utils.hpp  
  src/resource_provider/storage/volume_profile_utils.cpp  
  src/tests/volume_profile_tests.cpp  


Diff: https://reviews.apache.org/r/64972/diff/1/


Testing
-------

See next patch.

The two patches will probably be squashed together before commit.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message