mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 63860: Windows: Mapped the Docker network info types.
Date Fri, 05 Jan 2018 01:15:52 GMT


> On Jan. 4, 2018, 8:42 p.m., Jie Yu wrote:
> > I like the direction in the latest diff (platform specific defaults).
> > 
> > One question is: what's the difference between nat and bridge? are they the same?
If yes, can we not have NAT in the API? In other words, BRIDGE on Windows will map to "nat".
> 
> Akash Gupta wrote:
>     I don't remember if they are 100% the same, but they are very similar. We can map
BRIDGE to "nat" on Windows with a note in the doc that says that BRIDGE="nat" on Windows.

Yes, please do that.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63860/#review194784
-----------------------------------------------------------


On Jan. 5, 2018, 12:29 a.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63860/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2018, 12:29 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman,
Jie Yu, John Kordich, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-7342
>     https://issues.apache.org/jira/browse/MESOS-7342
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The current Network enum in DockerInfo is specific to Linux containers.
> Instead of supporting {host, bridge, none, user} networks, Windows
> docker supports {nat, none, user} networks. Now, the Network enum
> supports {host, bridge, nat, none, user}. If the network isn't
> specified, then the default is host on Linux and nat on Windows.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto c677a8be07d0ef209d42622ae32056d36e55ff78 
>   src/docker/docker.cpp 722a54ad113fc4e2bb22a8f08e307ab38d5fbfed 
> 
> 
> Diff: https://reviews.apache.org/r/63860/diff/5/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/63862/ for test results.
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message