mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ilya Pronin <ipro...@twopensource.com>
Subject Review Request 64938: Fixed RecoverTest.CatchupTruncated test flakiness.
Date Thu, 04 Jan 2018 00:07:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64938/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Bugs: MESOS-8377
    https://issues.apache.org/jira/browse/MESOS-8377


Repository: mesos


Description
-------

Most likely the "lock already held by process" LevelDB error was caused
by a Shared<Replica> still retained by one of the processes when the
test tries to recreate it. This change makes sure that the test code is
the only owner of the replica.


Diffs
-----

  src/tests/log_tests.cpp 7554a1e281323222d3be12aa1ec6fd809799ff65 


Diff: https://reviews.apache.org/r/64938/diff/1/


Testing
-------

Ran `./src/mesos-tests --gtest_filter='RecoverTest.CatchupTruncated' --gtest_repeat=1000 --gtest_break_on_failure=1`.


Thanks,

Ilya Pronin


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message