mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Review Request 64930: Unified the marking agent unreachable logic in the master.
Date Wed, 03 Jan 2018 22:48:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64930/
-----------------------------------------------------------

Review request for mesos, Benno Evers and Vinod Kone.


Repository: mesos


Description
-------

The logic for marking an agent unreachable in the master had two
very similar code paths that differed slightly across failover
and steady state cases. This patch uses a single code path.

Unfortunately, some slight differences were necessary, and a
failover boolean was introduced to accomodate them. Specifically,
the failover and steady state cases expect the agent to reside
in the recovered and registered lists, respectively.


Diffs
-----

  src/master/master.hpp 8fe9420dbe03ea2cefc6a40b0f64284aa9fe7915 
  src/master/master.cpp 03eb178fa1af7d55ae387e6cb42cdc8d721a2196 
  src/tests/slave_tests.cpp fb49077d7cb81db450d9fa24f75dbd9c79ef645c 


Diff: https://reviews.apache.org/r/64930/diff/1/


Testing
-------

make check


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message