mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 64868: Added initial doc about CSI support in Mesos.
Date Wed, 03 Jan 2018 21:37:48 GMT


> On Dec. 29, 2017, 3:03 p.m., James DeFelice wrote:
> > docs/csi.md
> > Lines 415 (patched)
> > <https://reviews.apache.org/r/64868/diff/2/?file=1929134#file1929134line415>
> >
> >     this is a protobuf3 type, for which there are specific rules re: JSON-ification:
https://developers.google.com/protocol-buffers/docs/proto3#json
> >     
> >     In particular:
> >     > Message field names are mapped to lowerCamelCase and become JSON object
keys. null is accepted and treated as the default value of the corresponding field type.
> >     
> >     This difference is probably important to note. The example provided continues
to use snake_case for protobuf3 json fields (e.g. fs_type vs fsType).

In fact, I changed it back. See tests here
https://github.com/apache/mesos/blob/master/src/tests/volume_profile_tests.cpp#L394-L438


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64868/#review194600
-----------------------------------------------------------


On Jan. 3, 2018, 5:09 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64868/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2018, 5:09 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gaston Kleiman, Greg Mann,
Joseph Wu, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added initial doc about CSI support in Mesos.
> 
> 
> Diffs
> -----
> 
>   docs/csi.md PRE-CREATION 
>   docs/home.md 0fa901fce91cc5e385c310f5e441c85678568547 
>   docs/images/csi-architecture.png PRE-CREATION 
>   docs/operator-http-api.md af6a3a6ec7d80859b640c8b7db49f93a803d55d0 
> 
> 
> Diff: https://reviews.apache.org/r/64868/diff/3/
> 
> 
> Testing
> -------
> 
> The rendering can be checked here:
> https://github.com/jieyu/mesos/blob/csi_doc/docs/csi.md
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message