mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <...@jxu.me>
Subject Re: Review Request 64898: Removed duplicated code that tests for removable tasks.
Date Wed, 03 Jan 2018 19:07:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64898/#review194706
-----------------------------------------------------------




src/master/master.cpp
Lines 10171 (patched)
<https://reviews.apache.org/r/64898/#comment273641>

    Would it be simpler to just use the new variable without a lambda?
    
    ```
    TaskState newState = latestState.getOrElse(status.state());
    ```


- Jiang Yan Xu


On Jan. 2, 2018, 4:26 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64898/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2018, 4:26 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When we get a task update and check whether the latest state
> indicated that the task is removable, invoke a local lambda
> function so that we don't duplicate the same code for both
> the current and latest states.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 03eb178fa1af7d55ae387e6cb42cdc8d721a2196 
> 
> 
> Diff: https://reviews.apache.org/r/64898/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message