mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 64889: Fixed handling of checkpointed resources for RP-capable agents.
Date Wed, 03 Jan 2018 19:01:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64889/#review194703
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/slave_recovery_tests.cpp
Lines 4990 (patched)
<https://reviews.apache.org/r/64889/#comment273639>

    2 lines apart


- Jie Yu


On Jan. 2, 2018, 5:27 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64889/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2018, 5:27 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8350
>     https://issues.apache.org/jira/browse/MESOS-8350
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The master will not resend checkpointed resources when a resource
> provider-capable agent reregisters. Instead the checkpointed resources
> sent as part of the agent reregistration should be evaluated by the
> master and be used to update its state.
> 
> This patch fixes the handling of checkpointed resources sent as part
> of the agent reregistration so that the resources are used to update
> the master state.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 8fe9420dbe03ea2cefc6a40b0f64284aa9fe7915 
>   src/master/master.cpp 04378a8d931ebe5f2667399ec9ce4225fa8c7c82 
>   src/tests/slave_recovery_tests.cpp bf2c5fcabdd4c16bdf5de1b641060e38783b8ee8 
> 
> 
> Diff: https://reviews.apache.org/r/64889/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message