mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 64888: Added check for handling of checkpointed resources in reregistration.
Date Wed, 03 Jan 2018 11:40:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64888/#review194691
-----------------------------------------------------------


Ship it!




The patch itself looks good, but you should replace 'check' with 'test' in the commit message.

- Benno Evers


On Jan. 2, 2018, 5:27 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64888/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2018, 5:27 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8350
>     https://issues.apache.org/jira/browse/MESOS-8350
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a check that confirms that the master resends
> checkpointed resources to the agent on reregistration.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_recovery_tests.cpp bf2c5fcabdd4c16bdf5de1b641060e38783b8ee8 
> 
> 
> Diff: https://reviews.apache.org/r/64888/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message