mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 64868: Added initial doc about CSI support in Mesos.
Date Wed, 03 Jan 2018 00:07:41 GMT


> On Jan. 2, 2018, 7:49 p.m., Greg Mann wrote:
> > docs/csi.md
> > Lines 109 (patched)
> > <https://reviews.apache.org/r/64868/diff/2/?file=1929134#file1929134line109>
> >
> >     I'm curious: is this accurate as written, or would "must not be set by frameworks"
be more appropriate?
> >     
> >     Similar question regarding the comment for `metadata`.

Yeah, clarified that these two fields must not be set by framweorks.


> On Jan. 2, 2018, 7:49 p.m., Greg Mann wrote:
> > docs/csi.md
> > Lines 192 (patched)
> > <https://reviews.apache.org/r/64868/diff/2/?file=1929134#file1929134line192>
> >
> >     Will we duplicate these offer operation docs in the scheduler API documentation?
To avoid duplication, we could instead add these instructions to the scheduler API docs, and
simply have a link here with a couple sentences explaining what these operations are used
for.

the scheduler API doc is not complete currently. I'll leave this as is for now. The scheduler
API doc (expecially ACCEPT) needs a major improvement, especially around `OPERATIONS`.


> On Jan. 2, 2018, 7:49 p.m., Greg Mann wrote:
> > docs/csi.md
> > Lines 289-290 (patched)
> > <https://reviews.apache.org/r/64868/diff/2/?file=1929134#file1929134line289>
> >
> >     Is it better to just say "by looking at the resources in subsequent offers"?
Are there other sources of information schedulers should use?

They could use operator endpoint (e.g., state).


> On Jan. 2, 2018, 7:49 p.m., Greg Mann wrote:
> > docs/csi.md
> > Lines 291-296 (patched)
> > <https://reviews.apache.org/r/64868/diff/2/?file=1929134#file1929134line291>
> >
> >     Should we also touch on the issue of roles w.r.t. receiving the converted resource
in an offer?
> >     
> >     Are volumes created by the new operations similar to persistent volumes in that
they can only be performed on reserved resources?

no, new operation can be used on non-reserved resources.


> On Jan. 2, 2018, 7:49 p.m., Greg Mann wrote:
> > docs/csi.md
> > Lines 298 (patched)
> > <https://reviews.apache.org/r/64868/diff/2/?file=1929134#file1929134line298>
> >
> >     I would recommend simply ommitting this section until we implement it.

OK, i'll mention the limitations and don't mention the protobuf.


> On Jan. 2, 2018, 7:49 p.m., Greg Mann wrote:
> > docs/csi.md
> > Lines 537-539 (patched)
> > <https://reviews.apache.org/r/64868/diff/2/?file=1929134#file1929134line537>
> >
> >     Are these strictly necessary for SLRP support?

Yes. It's unrelated, but these must be specified because the agent code for handling the old
way has been removed already. add a note.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64868/#review194631
-----------------------------------------------------------


On Dec. 29, 2017, 4:53 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64868/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2017, 4:53 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gaston Kleiman, Greg Mann,
Joseph Wu, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added initial doc about CSI support in Mesos.
> 
> 
> Diffs
> -----
> 
>   docs/csi.md PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/64868/diff/2/
> 
> 
> Testing
> -------
> 
> The rendering can be checked here:
> https://github.com/jieyu/mesos/blob/csi_doc/docs/csi.md
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message