mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gaston Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 64898: Removed duplicated code that tests for removable tasks.
Date Tue, 02 Jan 2018 22:43:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64898/#review194661
-----------------------------------------------------------



I think that you need to rebase this RR.

- Gaston Kleiman


On Jan. 2, 2018, 1:43 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64898/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2018, 1:43 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When we get a task update and check whether the latest state
> indicated that the task is removable, invoke a local lambda
> function so that we don't duplicate the same code for both
> the current and latest states.
> 
> 
> Diffs
> -----
> 
>   docs/configuration/master.md 3ff97ea5dbae12e17cb137d1367b98130dce9596 
>   src/master/flags.hpp dabb414560f506787b6e821a27af623c8da44b11 
>   src/master/flags.cpp b49cb63bfebb286ae4f5e665652dc5f8f2964ceb 
>   src/master/master.cpp 03eb178fa1af7d55ae387e6cb42cdc8d721a2196 
>   src/tests/master_tests.cpp 5546fd937d078c1f757964d5163449ffd993388e 
> 
> 
> Diff: https://reviews.apache.org/r/64898/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message