mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 64694: Cleaned up `ResourceProviderManagerHttpApiTest.ConvertResources`.
Date Tue, 02 Jan 2018 21:42:51 GMT


> On Jan. 2, 2018, 8:56 p.m., Greg Mann wrote:
> > src/tests/resource_provider_manager_tests.cpp
> > Line 1032 (original), 1017 (patched)
> > <https://reviews.apache.org/r/64694/diff/1/?file=1922393#file1922393line1035>
> >
> >     It does work to declare this as a const ref, but a bit weird. Let's just make
it
> >     `const v1::Offer offer1`
> >     
> >     and `offer2` below as well.
> 
> Gaston Kleiman wrote:
>     This is a very common pattern in `default_executor_tests.cpp`, should we change it
there as well?

Ah good point, I suppose we just do it to avoid an extra copy. I'll just drop it.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64694/#review194649
-----------------------------------------------------------


On Dec. 19, 2017, 12:04 a.m., Gaston Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64694/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2017, 12:04 a.m.)
> 
> 
> Review request for mesos, Greg Mann, Jie Yu, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch makes the test follow the pattern used by the Default
> Executor tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/resource_provider_manager_tests.cpp 4e86016a450c30fea90e9c6e5c1f2f1aab5f42c0

> 
> 
> Diff: https://reviews.apache.org/r/64694/diff/1/
> 
> 
> Testing
> -------
> 
> The test passed 500 times on GNU/Linux.
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message