mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 64891: Future-proofed use of agent capabilities in tests.
Date Tue, 02 Jan 2018 17:23:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64891/
-----------------------------------------------------------

Review request for mesos, Benno Evers and Jie Yu.


Repository: mesos


Description
-------

Even though currently the resource provider capability is the only
capability which can be toggled by users, when examining agent flags
we expect either no capabilities at all or a full set of capabilities
(including both toggleable and required capabilities).

This patch cleans up test code agent capabilities by delegating the
bulk of the work to a helper function providing a set of
default-enabled capabilities and only adds a single capability to that
set. This not only makes it clearer which exact capability a test
cares about, but also future-proofs the code for the case where we
extend the set of required capabilities in the future.


Diffs
-----

  src/tests/agent_resource_provider_config_api_tests.cpp f2486cbf5cf9599ed3bd1caa3b1f660ddcb9d15f

  src/tests/api_tests.cpp 9246f4222548f8d19a8f4f89fb3c22ecae5b58b0 
  src/tests/persistent_volume_tests.cpp 372037f5121dfcf80ec02affdb6e9eee4029dedf 
  src/tests/reservation_tests.cpp 938306ed882f5bc94cd373653af30d09dd4b42d9 
  src/tests/resource_provider_manager_tests.cpp 096747ee0bfed953f6f72687b5f8faffaacc7f6a 
  src/tests/slave_tests.cpp fb49077d7cb81db450d9fa24f75dbd9c79ef645c 
  src/tests/storage_local_resource_provider_tests.cpp 22b81a5c2fcca1e97a6e7d4bde790fc21022d362



Diff: https://reviews.apache.org/r/64891/diff/1/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message