mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andy Pang <pangbingqi...@huawei.com>
Subject Re: Review Request 63437: Slave heartbeat add message sender distinguish.
Date Tue, 02 Jan 2018 02:52:05 GMT


> On 十一月 3, 2017, 10:26 p.m., Vinod Kone wrote:
> > src/slave/slave.cpp
> > Lines 4996-5001 (patched)
> > <https://reviews.apache.org/r/63437/diff/1/?file=1873291#file1873291line4996>
> >
> >     Can you explain the context for this change? The change itself seems reasonable,
but I would like to understand what prompted you to add this.

we meet double master leader, and the incorrect leader send the ping-pong to the agent, agent
can't recognize even if it detect the real correct leader.


- Andy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63437/#review190074
-----------------------------------------------------------


On 十月 31, 2017, 3:45 a.m., Andy Pang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63437/
> -----------------------------------------------------------
> 
> (Updated 十月 31, 2017, 3:45 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Slave ping-pong message add master from judge.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 337083d 
> 
> 
> Diff: https://reviews.apache.org/r/63437/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message