mesos-reviews mailing list archives: December 2017

Site index · List index
Message list« Previous · 1 · 2 · 3 · 4 · 5 · 6 · 7 · 8 · 9 · 10 · Next »Thread · Author · Date
Alexander Rukletsov Review Request 64685: Improved the comment around the union in ns::clone(). Mon, 18 Dec, 19:06
Armand Grillet   Re: Review Request 64685: Improved the comment around the union in ns::clone(). Mon, 18 Dec, 21:40
Alexander Rukletsov   Re: Review Request 64685: Improved the comment around the union in ns::clone(). Fri, 22 Dec, 13:42
Benjamin Bannier     Re: Review Request 64685: Improved the comment around the union in ns::clone(). Fri, 22 Dec, 14:29
Alexander Rukletsov       Re: Review Request 64685: Improved the comment around the union in ns::clone(). Fri, 22 Dec, 14:33
Re: Review Request 64070: Ensured executor adapter propagates error and shutdown messages.
Vinod Kone   Re: Review Request 64070: Ensured executor adapter propagates error and shutdown messages. Mon, 18 Dec, 23:10
Alexander Rukletsov   Re: Review Request 64070: Ensured executor adapter propagates error and shutdown messages. Wed, 20 Dec, 16:12
Alexander Rukletsov     Re: Review Request 64070: Ensured executor adapter propagates error and shutdown messages. Wed, 20 Dec, 16:27
Alexander Rukletsov       Re: Review Request 64070: WIP: Ensured executor adapter propagates error and shutdown messages. Wed, 20 Dec, 16:27
Mesos Reviewbot Windows         Re: Review Request 64070: WIP: Ensured executor adapter propagates error and shutdown messages. Wed, 20 Dec, 18:10
Alexander Rukletsov         Re: Review Request 64070: Ensured executor adapter propagates error and shutdown messages. Wed, 20 Dec, 20:16
Andrei Budnik           Re: Review Request 64070: Ensured executor adapter propagates error and shutdown messages. Thu, 21 Dec, 15:03
Andrei Budnik           Re: Review Request 64070: Ensured executor adapter propagates error and shutdown messages. Thu, 21 Dec, 15:03
Alexander Rukletsov           Re: Review Request 64070: Ensured executor adapter propagates error and shutdown messages. Thu, 21 Dec, 15:40
Alexander Rukletsov             Re: Review Request 64070: Ensured executor adapter propagates error and shutdown messages. Thu, 21 Dec, 16:07
Alexander Rukletsov               Re: Review Request 64070: Ensured executor adapter propagates error and shutdown messages. Fri, 22 Dec, 11:08
Gaston Kleiman Review Request 64694: Cleaned up `ResourceProviderManagerHttpApiTest.ConvertResources`. Tue, 19 Dec, 00:04
Mesos Reviewbot Windows   Re: Review Request 64694: Cleaned up `ResourceProviderManagerHttpApiTest.ConvertResources`. Tue, 19 Dec, 02:10
Gaston Kleiman Review Request 64695: Improved the comments describing the offer operation states. Tue, 19 Dec, 00:54
Mesos Reviewbot Windows   Re: Review Request 64695: Improved the comments describing the offer operation states. Tue, 19 Dec, 03:13
Andrew Schwartzmeyer Review Request 64697: Windows: Deleted unused and unnecessary OS version functions. Tue, 19 Dec, 02:07
Mesos Reviewbot Windows   Re: Review Request 64697: Windows: Deleted unused and unnecessary OS version functions. Tue, 19 Dec, 03:10
Joseph Wu   Re: Review Request 64697: Windows: Deleted unused and unnecessary OS version functions. Tue, 19 Dec, 21:28
Meng Zhu Review Request 64698: Made quota headroom calculation on a per-role basis. Tue, 19 Dec, 03:01
Benjamin Mahler   Re: Review Request 64698: Made quota headroom calculation on a per-role basis. Tue, 19 Dec, 05:14
Meng Zhu Review Request 64699: Added a test to ensure quota headroom is maintained. Tue, 19 Dec, 03:02
Mesos Reviewbot Windows   Re: Review Request 64699: Added a test to ensure quota headroom is maintained. Tue, 19 Dec, 04:13
Benjamin Mahler   Re: Review Request 64699: Added a test to ensure quota headroom is maintained. Tue, 19 Dec, 05:12
Andrew Schwartzmeyer Review Request 64689: Windows: Fixed `os::open()` to always use `O_BINARY`. Tue, 19 Dec, 03:34
Gaston Kleiman   Re: Review Request 64689: Windows: Fixed `os::open()` to always use `O_BINARY`. Tue, 19 Dec, 05:32
Jeff Coffler   Re: Review Request 64689: Windows: Fixed `os::open()` to always use `O_BINARY`. Tue, 19 Dec, 19:27
Andrew Schwartzmeyer Review Request 64690: Windows: Removed manual use of `O_BINARY`. Tue, 19 Dec, 03:35
Mesos Reviewbot Windows   Re: Review Request 64690: Windows: Removed manual use of `O_BINARY`. Tue, 19 Dec, 04:45
Jeff Coffler   Re: Review Request 64690: Windows: Removed manual use of `O_BINARY`. Tue, 19 Dec, 19:25
Gaston Kleiman   Re: Review Request 64690: Windows: Removed manual use of `O_BINARY`. Tue, 19 Dec, 19:26
Mesos Reviewbot Windows   Re: Review Request 64690: Windows: Removed manual use of `O_BINARY`. Tue, 19 Dec, 20:13
Andrew Schwartzmeyer Review Request 64701: Windows: Added `/EHsc` to `CMAKE_CXX_FLAGS`. Tue, 19 Dec, 03:44
Mesos Reviewbot Windows   Re: Review Request 64701: Windows: Added `/EHsc` to `CMAKE_CXX_FLAGS`. Tue, 19 Dec, 04:44
Mesos Reviewbot Windows   Re: Review Request 64701: Windows: Added `/EHsc` to `CMAKE_CXX_FLAGS`. Tue, 19 Dec, 20:10
Eric Mumau via Review Board   Re: Review Request 64701: Windows: Added `/EHsc` to `CMAKE_CXX_FLAGS`. Tue, 19 Dec, 22:46
Re: Review Request 59987: Added protobuf map support.
Qian Zhang   Re: Review Request 59987: Added protobuf map support. Tue, 19 Dec, 13:49
Qian Zhang   Re: Review Request 59987: Added protobuf map support. Tue, 19 Dec, 13:50
Qian Zhang   Re: Review Request 59987: Added protobuf map support. Thu, 21 Dec, 02:07
Qian Zhang   Re: Review Request 59987: Added protobuf map support. Wed, 27 Dec, 01:28
Re: Review Request 59988: Added a new protobuf message `MapMessage` for protobuf tests.
Qian Zhang   Re: Review Request 59988: Added a new protobuf message `MapMessage` for protobuf tests. Tue, 19 Dec, 13:52
Re: Review Request 59989: Added a test `ProtobufTest.JsonifyMap`.
Qian Zhang   Re: Review Request 59989: Added a test `ProtobufTest.JsonifyMap`. Tue, 19 Dec, 13:52
Chun-Hung Hsiao Review Request 64692: Dropping instead of failing offer operations with mismatched versions. Tue, 19 Dec, 14:27
Jie Yu   Re: Review Request 64692: Dropping instead of failing offer operations with mismatched versions. Tue, 19 Dec, 19:23
Chun-Hung Hsiao Review Request 64711: Added logging for container daemon. Tue, 19 Dec, 14:28
Mesos Reviewbot Windows   Re: Review Request 64711: Added logging for container daemon. Tue, 19 Dec, 14:30
Jie Yu   Re: Review Request 64711: Added logging for container daemon. Tue, 19 Dec, 19:24
Jan Schlicht Review Request 64713: Fixed a crash when resubscribing resource providers. Tue, 19 Dec, 15:14
Benjamin Bannier   Re: Review Request 64713: Fixed a crash when resubscribing resource providers. Tue, 19 Dec, 15:28
Jan Schlicht     Re: Review Request 64713: Fixed a crash when resubscribing resource providers. Wed, 20 Dec, 13:38
Mesos Reviewbot Windows   Re: Review Request 64713: Fixed a crash when resubscribing resource providers. Tue, 19 Dec, 16:13
Jan Schlicht   Re: Review Request 64713: Fixed a crash when resubscribing resource providers. Wed, 20 Dec, 13:24
Mesos Reviewbot Windows     Re: Review Request 64713: Fixed a crash when resubscribing resource providers. Wed, 20 Dec, 14:22
Benjamin Bannier     Re: Review Request 64713: Fixed a crash when resubscribing resource providers. Thu, 21 Dec, 09:14
Re: Review Request 62161: Update boost version.
Andrew Schwartzmeyer   Re: Review Request 62161: Update boost version. Tue, 19 Dec, 19:09
Jeff Coffler Review Request 64720: Upgraded to use cURL v7.57.0 on Windows Platform. Tue, 19 Dec, 19:33
Andrew Schwartzmeyer   Re: Review Request 64720: Upgraded to use cURL v7.57.0 on Windows Platform. Tue, 19 Dec, 19:35
Andrew Schwartzmeyer     Re: Review Request 64720: Upgraded to use cURL v7.57.0 on Windows Platform. Tue, 19 Dec, 19:38
Mesos Reviewbot Windows   Re: Review Request 64720: Upgraded to use cURL v7.57.0 on Windows Platform. Tue, 19 Dec, 21:12
Jeff Coffler     Re: Review Request 64720: Upgraded to use cURL v7.57.0 on Windows Platform. Tue, 19 Dec, 22:27
Andrew Schwartzmeyer     Re: Review Request 64720: Upgraded to use cURL v7.57.0 on Windows Platform. Tue, 19 Dec, 22:38
Andrew Schwartzmeyer     Re: Review Request 64720: Upgraded to use cURL v7.57.0 on Windows Platform. Tue, 19 Dec, 22:44
Chun-Hung Hsiao Review Request 64725: Refactred `UriVolumeProfileAdaptor` and `VolumeProfileTest`. Tue, 19 Dec, 22:17
Mesos Reviewbot Windows   Re: Review Request 64725: Refactored `UriVolumeProfileAdaptor` and `VolumeProfileTest`. Tue, 19 Dec, 23:14
Jie Yu   Re: Review Request 64725: Refactored `UriVolumeProfileAdaptor` and `VolumeProfileTest`. Tue, 19 Dec, 23:14
Gaston Kleiman Review Request 64726: Renamed operation protos for consistency. Wed, 20 Dec, 00:12
Chun-Hung Hsiao   Re: Review Request 64726: Renamed operation protos for consistency. Wed, 20 Dec, 00:27
Chun-Hung Hsiao   Re: Review Request 64726: Renamed operation protos for consistency. Wed, 20 Dec, 00:38
Gaston Kleiman   Re: Review Request 64726: Renamed operation protos for consistency. Wed, 20 Dec, 00:57
Mesos Reviewbot Windows     Re: Review Request 64726: Renamed operation protos for consistency. Wed, 20 Dec, 01:08
Greg Mann     Re: Review Request 64726: Renamed operation protos for consistency. Wed, 20 Dec, 01:38
Gaston Kleiman       Re: Review Request 64726: Renamed operation protos for consistency. Wed, 20 Dec, 02:05
Gaston Kleiman       Re: Review Request 64726: Renamed operation protos for consistency. Wed, 20 Dec, 02:52
Gaston Kleiman     Re: Review Request 64726: Renamed operation protos for consistency. Wed, 20 Dec, 02:53
Mesos Reviewbot Windows       Re: Review Request 64726: Renamed operation protos for consistency. Wed, 20 Dec, 03:29
Jie Yu       Re: Review Request 64726: Renamed operation protos for consistency. Wed, 20 Dec, 18:05
Gaston Kleiman       Re: Review Request 64726: Renamed operation protos for consistency. Wed, 20 Dec, 19:21
Jie Yu         Re: Review Request 64726: Renamed operation protos for consistency. Wed, 20 Dec, 19:27
Greg Mann         Re: Review Request 64726: Renamed operation protos for consistency. Wed, 20 Dec, 19:41
Mesos Reviewbot Windows         Re: Review Request 64726: Renamed operation protos for consistency. Wed, 20 Dec, 19:49
Chun-Hung Hsiao Review Request 64727: Moved files related to volume profiles into `resource_provider/storage`. Wed, 20 Dec, 00:20
Mesos Reviewbot Windows   Re: Review Request 64727: Moved files related to volume profiles into `resource_provider/storage`. Wed, 20 Dec, 02:03
Michael Park Review Request 64737: Added validation / normalized resources for storage-related operations. Wed, 20 Dec, 00:49
Jie Yu   Re: Review Request 64737: Added validation / normalized resources for storage-related operations. Wed, 20 Dec, 01:18
Benjamin Mahler   Re: Review Request 64737: Added validation / normalized resources for storage-related operations. Wed, 20 Dec, 02:09
Michael Park Review Request 64739: Upgraded resources that come from `protobuf::read`. Wed, 20 Dec, 00:51
Mesos Reviewbot Windows   Re: Review Request 64739: Upgraded resources that come from `protobuf::read`. Wed, 20 Dec, 01:58
Benjamin Mahler   Re: Review Request 64739: Upgraded resources that come from `protobuf::read`. Fri, 22 Dec, 02:55
Michael Park Review Request 64738: Pulled out `upgradeResources` out of `validateAndNormalizeResources`. Wed, 20 Dec, 00:51
Benjamin Mahler   Re: Review Request 64738: Pulled out `upgradeResources` out of `validateAndNormalizeResources`. Wed, 20 Dec, 02:13
Michael Park     Re: Review Request 64738: Pulled out `upgradeResources` out of `validateAndNormalizeResources`. Thu, 28 Dec, 04:50
Michael Park Review Request 63978: Added tests for protobuf reflection-based `downgradeResources`. Wed, 20 Dec, 00:52
Benjamin Mahler Review Request 64741: Eliminated some unnecessary copying in the HTTP operator API. Wed, 20 Dec, 01:47
Mesos Reviewbot Windows   Re: Review Request 64741: Eliminated some unnecessary copying in the HTTP operator API. Wed, 20 Dec, 03:03
Meng Zhu   Re: Review Request 64741: Eliminated some unnecessary copying in the HTTP operator API. Wed, 20 Dec, 19:52
Benjamin Mahler     Re: Review Request 64741: Eliminated some unnecessary copying in the HTTP operator API. Thu, 21 Dec, 01:33
Meng Zhu   Re: Review Request 64741: Eliminated some unnecessary copying in the HTTP operator API. Thu, 21 Dec, 00:37
Jie Yu Review Request 64742: Made volume secret isolator not standalone container aware. Wed, 20 Dec, 03:36
Chun-Hung Hsiao   Re: Review Request 64742: Made volume secret isolator not standalone container aware. Wed, 20 Dec, 03:39
Mesos Reviewbot Windows   Re: Review Request 64742: Made volume secret isolator not standalone container aware. Wed, 20 Dec, 04:33
Andrew Schwartzmeyer Review Request 64729: Made `Duration::operator*` accept `int` and `size_t`. Wed, 20 Dec, 03:40
Mesos Reviewbot Windows   Re: Review Request 64729: Made `Duration::operator*` accept `int` and `size_t`. Wed, 20 Dec, 04:30
Andrew Schwartzmeyer Review Request 64730: Changed `Sorter::count()` to return `size_t` instead of `int`. Wed, 20 Dec, 03:40
Andrew Schwartzmeyer Review Request 64731: Ended `IOSwitchboard::_prepare` with `UNREACHABLE`. Wed, 20 Dec, 03:41
Andrew Schwartzmeyer Review Request 64732: Fixed conversion warnings in tests. Wed, 20 Dec, 03:41
Andrew Schwartzmeyer Review Request 64733: Fixed conversion warnings in tests. Wed, 20 Dec, 03:41
Andrew Schwartzmeyer Review Request 64734: Fixed conversion warnings. Wed, 20 Dec, 03:43
Andrew Schwartzmeyer Review Request 64735: Fixed conversion warnings in tests. Wed, 20 Dec, 03:43
Andrew Schwartzmeyer Review Request 64736: Fixed conversion warnings. Wed, 20 Dec, 03:45
Mesos Reviewbot Windows   Re: Review Request 64736: Fixed conversion warnings. Wed, 20 Dec, 04:40
James Peach Review Request 64743: Enabled function sections. Wed, 20 Dec, 03:50
Andrew Schwartzmeyer   Re: Review Request 64743: Enabled function sections. Wed, 20 Dec, 04:08
Mesos Reviewbot Windows   Re: Review Request 64743: Enabled function sections. Wed, 20 Dec, 05:30
Benjamin Bannier   Re: Review Request 64743: Enabled function sections. Wed, 20 Dec, 10:52
James Peach     Re: Review Request 64743: Enabled function sections. Thu, 21 Dec, 02:02
James Peach   Re: Review Request 64743: Enabled function sections. Thu, 21 Dec, 01:47
Mesos Reviewbot Windows     Re: Review Request 64743: Enabled function sections. Thu, 21 Dec, 02:53
Re: Review Request 64450: Update docs to mention new '--reconfiguration_policy' flag.
Alexander Rukletsov   Re: Review Request 64450: Update docs to mention new '--reconfiguration_policy' flag. Wed, 20 Dec, 11:27
Benno Evers     Re: Review Request 64450: Update docs to mention new flag. Wed, 20 Dec, 13:40
Benno Evers   Re: Review Request 64450: Update docs to mention new flag. Wed, 20 Dec, 13:26
Alexander Rukletsov     Re: Review Request 64450: Update docs to mention new flag. Wed, 20 Dec, 13:48
Benno Evers     Re: Review Request 64450: Update docs to mention new flag. Wed, 20 Dec, 14:11
Mesos Reviewbot Windows       Re: Review Request 64450: Update docs to mention new flag. Wed, 20 Dec, 14:19
Andrei Budnik Review Request 64749: Fixed flaky `NestedMesosContainerizerTest` tests. Wed, 20 Dec, 13:50
Alexander Rukletsov   Re: Review Request 64749: Fixed flaky `NestedMesosContainerizerTest` tests. Wed, 20 Dec, 13:55
Andrei Budnik   Re: Review Request 64749: Fixed flaky `NestedMesosContainerizerTest` tests. Wed, 20 Dec, 13:59
Benjamin Bannier Review Request 64750: Fixed an agent assertion. Wed, 20 Dec, 14:22
Mesos Reviewbot Windows   Re: Review Request 64750: Fixed an agent assertion. Wed, 20 Dec, 15:22
Jie Yu   Re: Review Request 64750: Fixed an agent assertion. Wed, 20 Dec, 16:05
Meng Zhu Review Request 64758: Added a test to ensure MOUNT disk resource is allocated exclusively. Wed, 20 Dec, 22:07
Mesos Reviewbot Windows   Re: Review Request 64758: Added a test to ensure MOUNT disk resource is allocated exclusively. Wed, 20 Dec, 22:10
Benjamin Mahler   Re: Review Request 64758: Added a test to ensure MOUNT disk resource is allocated exclusively. Thu, 21 Dec, 01:48
Meng Zhu   Re: Review Request 64758: Added a test to ensure MOUNT disk is not chopped during allocation. Thu, 21 Dec, 02:48
Benjamin Mahler     Re: Review Request 64758: Added a test to ensure MOUNT disk is not chopped during allocation. Thu, 21 Dec, 02:51
Message list« Previous · 1 · 2 · 3 · 4 · 5 · 6 · 7 · 8 · 9 · 10 · Next »Thread · Author · Date
Box list
Oct 202120
Sep 202135
Aug 202118
Jul 202145
Jun 2021122
May 2021118
Apr 20215
Mar 20214
Feb 20215
Jan 202144
Dec 202017
Nov 202011
Oct 202050
Sep 2020188
Aug 2020388
Jul 2020125
Jun 202033
May 2020154
Apr 2020285
Mar 2020342
Feb 2020191
Jan 2020303
Dec 2019159
Nov 2019239
Oct 2019162
Sep 2019312
Aug 2019540
Jul 2019707
Jun 2019621
May 2019472
Apr 2019702
Mar 2019955
Feb 2019758
Jan 2019749
Dec 2018455
Nov 2018598
Oct 2018832
Sep 2018704
Aug 20181218
Jul 20181040
Jun 20181026
May 20181520
Apr 20181445
Mar 20181350
Feb 20181396
Jan 20181470
Dec 20171464
Nov 20171769
Oct 20171445
Sep 20171054
Aug 20171341
Jul 20171295
Jun 20171475
May 20171547
Apr 20171266
Mar 20172102
Feb 20171631
Jan 20171655
Dec 20161774
Nov 20162300
Oct 20162196
Sep 20162748
Aug 20162311
Jul 20163001
Jun 20163216
May 20162928
Apr 20163332
Mar 20164025
Feb 20162997
Jan 20163700
Dec 20152431
Nov 20152744
Oct 20152284
Sep 20152621
Aug 20152300
Jul 20152051
Jun 20152449
May 20151444
Apr 2015338