From reviews-return-70944-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Dec 19 09:29:03 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1739F1095C for ; Tue, 19 Dec 2017 09:29:03 +0000 (UTC) Received: (qmail 93099 invoked by uid 500); 19 Dec 2017 09:29:02 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 93060 invoked by uid 500); 19 Dec 2017 09:29:02 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 93046 invoked by uid 99); 19 Dec 2017 09:29:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Dec 2017 09:29:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 362DC1A04CE; Tue, 19 Dec 2017 09:29:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 5.497 X-Spam-Level: ***** X-Spam-Status: No, score=5.497 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_NONE=-0.0001, RP_MATCHES_RCVD=-0.001, SUSPICIOUS_RECIPS=2.497] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 7dRUw1qwsyxH; Tue, 19 Dec 2017 09:28:59 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 1BE125F297; Tue, 19 Dec 2017 09:28:59 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 67940E0959; Tue, 19 Dec 2017 09:28:58 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 6BCA8C40253; Tue, 19 Dec 2017 09:28:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2247981926257914812==" MIME-Version: 1.0 Subject: Re: Review Request 64297: Updated modules documentation with some more details. From: Armand Grillet To: Kapil Arya , Benjamin Bannier , Armand Grillet Cc: Till Toenshoff , mesos Date: Tue, 19 Dec 2017 09:28:56 -0000 Message-ID: <20171219092856.54788.48294@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Armand Grillet X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/64297/ X-Sender: Armand Grillet References: <20171204132531.40731.35979@reviews-vm2.apache.org> In-Reply-To: <20171204132531.40731.35979@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: docs/hook.md Reply-To: Armand Grillet X-ReviewRequest-Repository: mesos --===============2247981926257914812== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64297/#review194134 ----------------------------------------------------------- docs/hook.md Lines 30 (patched) You use `slave` instead of `Agent` in other parts of this file. docs/hook.md Lines 56 (patched) This document contains `within slave` and `within the slave`, using the same wording every time would be cleaner. docs/hook.md Lines 61 (patched) The `a` can be removed. docs/hook.md Lines 72 (patched) s/`docker`/`Docker` docs/hook.md Lines 82 (patched) s/`the hook loaded last`/`the last hook loaded` docs/hook.md Lines 157 (patched) s/`attributes for`/`attributes of` docs/modules.md Lines 135 (patched) Even if no dedicated section exists for this module yet, could a one-liner description be added in this array? Same for the ones at the end of the array. docs/modules.md Lines 141 (patched) s/`implementubg`/`implementing` - Armand Grillet On Dec. 4, 2017, 1:25 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64297/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2017, 1:25 p.m.) > > > Review request for mesos, Armand Grillet, Benjamin Bannier, and Kapil Arya. > > > Bugs: MESOS-8016 > https://issues.apache.org/jira/browse/MESOS-8016 > > > Repository: mesos > > > Description > ------- > > Added mention of HTTP authenticatee module. Added mention of > authorizer modules. Added details around hook modules. > > > Diffs > ----- > > docs/hook.md PRE-CREATION > docs/modules.md c5231e242cfe42834beeb98846c9308e0fd8dff3 > > > Diff: https://reviews.apache.org/r/64297/diff/1/ > > > Testing > ------- > > > Thanks, > > Till Toenshoff > > --===============2247981926257914812==--