From reviews-return-70041-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Dec 5 00:13:16 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7403317CB5 for ; Tue, 5 Dec 2017 00:13:16 +0000 (UTC) Received: (qmail 5561 invoked by uid 500); 5 Dec 2017 00:13:16 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 5525 invoked by uid 500); 5 Dec 2017 00:13:16 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 5514 invoked by uid 99); 5 Dec 2017 00:13:16 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Dec 2017 00:13:16 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 02AB11A041B; Tue, 5 Dec 2017 00:13:15 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id xAS1lXQ1xEaq; Tue, 5 Dec 2017 00:13:13 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id AB2F95F3CF; Tue, 5 Dec 2017 00:13:12 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 13FF4E0161; Tue, 5 Dec 2017 00:13:12 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 98C5AC40A07; Tue, 5 Dec 2017 00:13:11 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0199838428129763583==" MIME-Version: 1.0 Subject: Re: Review Request 63340: Moved Java build code to `java/CMakeLists.txt`. From: Andrew Schwartzmeyer To: Benjamin Bannier , Jeff Coffler , John Kordich , Joseph Wu , Michael Park Cc: Andrew Schwartzmeyer , mesos Date: Tue, 05 Dec 2017 00:13:05 -0000 Message-ID: <20171205001305.40731.80469@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrew Schwartzmeyer X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63340/ X-Sender: Andrew Schwartzmeyer References: <20171204211919.13476.16564@reviews-vm2.apache.org> In-Reply-To: <20171204211919.13476.16564@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: src/java/CMakeLists.txt Reply-To: Andrew Schwartzmeyer X-ReviewRequest-Repository: mesos --===============0199838428129763583== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63340/ ----------------------------------------------------------- (Updated Dec. 4, 2017, 4:13 p.m.) Review request for mesos, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph Wu, and Michael Park. Changes ------- Add updated test results. Re-verifying Java build on Windows. Repository: mesos Description ------- Moved Java build code to `java/CMakeLists.txt`. Diffs ----- src/CMakeLists.txt 592489df070a0c4fdee814a4a7b613e62a544f88 src/java/CMakeLists.txt PRE-CREATION Diff: https://reviews.apache.org/r/63340/diff/3/ Testing (updated) ------- Built with `-DENABLE_JAVA=ON` and attached Marathon framework to `master` (which requries Java bindings). Also built and ran `mesos-tests` with the ZooKeeper unit tests (which use the Java components). Had to add `mesos-protobufs` as a dependency to `mesos-jar` to be totally correct. Update: thought I was going crazy seeing these: ``` [ FAILED ] 5 tests, listed below: [ FAILED ] ExamplesTest.JavaFramework [ FAILED ] ExamplesTest.JavaException [ FAILED ] ExamplesTest.JavaLog [ FAILED ] ExamplesTest.V0JavaFramework [ FAILED ] ExamplesTest.V1JavaFramework ``` but then remembered these are expected to fail as we still don't yet build the example java JAR file. ``` # TODO(andschwa): Build the Example JAR. set(EXAMPLE_JAR_SRC ../examples/java/TestExceptionFramework.java ../examples/java/TestExecutor.java ../examples/java/TestFramework.java ../examples/java/TestLog.java ../examples/java/TestMultipleExecutorsFramework.java ../examples/java/V1TestFramework.java) ``` Thanks, Andrew Schwartzmeyer --===============0199838428129763583==--