From reviews-return-70034-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Dec 4 23:15:03 2017 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C04A317A9C for ; Mon, 4 Dec 2017 23:15:03 +0000 (UTC) Received: (qmail 86756 invoked by uid 500); 4 Dec 2017 23:15:03 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 86720 invoked by uid 500); 4 Dec 2017 23:15:03 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 86709 invoked by uid 99); 4 Dec 2017 23:15:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Dec 2017 23:15:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 9BD3618078F; Mon, 4 Dec 2017 23:15:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.249 X-Spam-Level: *** X-Spam-Status: No, score=3.249 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Iw0_q-AExHLE; Mon, 4 Dec 2017 23:15:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 615995F2A9; Mon, 4 Dec 2017 23:15:00 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 14C1EE0161; Mon, 4 Dec 2017 23:15:00 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 97A00C40A07; Mon, 4 Dec 2017 23:14:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4045384138000185737==" MIME-Version: 1.0 Subject: Re: Review Request 64012: Added new --reconfiguration_compatibility slave flag and implementation. From: Vinod Kone To: Vinod Kone Cc: Benno Evers , mesos Date: Mon, 04 Dec 2017 23:14:58 -0000 Message-ID: <20171204231458.13476.1384@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Vinod Kone X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/64012/ X-Sender: Vinod Kone X-ReviewBoard-ShipIt: 1 References: <20171204163306.13476.14251@reviews-vm2.apache.org> In-Reply-To: <20171204163306.13476.14251@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: src/slave/compatibility.cpp X-ReviewBoard-Diff-For: src/slave/compatibility.hpp X-ReviewBoard-Diff-For: src/tests/slave_compatibility_tests.cpp Reply-To: Vinod Kone X-ReviewRequest-Repository: mesos --===============4045384138000185737== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64012/#review192788 ----------------------------------------------------------- Fix it, then Ship it! src/tests/master_tests.cpp Line 2738 (original), 2735 (patched) mvoe this to #2760 src/tests/slave_tests.cpp Lines 8912 (patched) what about testing the resources? src/tests/slave_recovery_tests.cpp Lines 4641 (patched) s/tests/test/ src/tests/slave_recovery_tests.cpp Line 4908 (original), 5043 (patched) single blank line. src/tests/slave_recovery_tests.cpp Lines 5088-5089 (patched) 2 extra blank lines? - Vinod Kone On Dec. 4, 2017, 4:33 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64012/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2017, 4:33 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > This flag allows operators to weaken the checks performed by the agent > when recovering state, in particular it allows to recover running tasks > even when parts of the recovered SlaveInfo don't match the current > state. > > The set of possible changes is quite restricted for now, > to avoid accidenetally introducing semantic bugs. > > > Diffs > ----- > > src/CMakeLists.txt 592489df070a0c4fdee814a4a7b613e62a544f88 > src/Makefile.am 08d29ab58fe5c7f5e0c9173b504787ec254ed99b > src/slave/compatibility.hpp PRE-CREATION > src/slave/compatibility.cpp PRE-CREATION > src/slave/flags.hpp f25d8aff29d0698eaf06dd40a86a35e43bc9e094 > src/slave/flags.cpp 34edf4cb4a1afc366e6b6b4ddf78e90e49853fdf > src/slave/slave.hpp 643d8559244f0842e82b293c1ef99cb26e111059 > src/slave/slave.cpp c07e25f668bef6b6fa3cae4b69ba90de3eb3bdcc > src/tests/CMakeLists.txt 5e5202079c9798b91028e845490b747d4d1d0a66 > src/tests/master_tests.cpp 08742ec878b29ef275fb40e857efffcf4c2f9ac2 > src/tests/slave_compatibility_tests.cpp PRE-CREATION > src/tests/slave_recovery_tests.cpp 7674e607ee5bb7efbceb81c3e7291bc558d69935 > src/tests/slave_tests.cpp a7f6658fa467914cd74691b5631d26d85ba7c1eb > > > Diff: https://reviews.apache.org/r/64012/diff/6/ > > > Testing > ------- > > > Thanks, > > Benno Evers > > --===============4045384138000185737==--