| Benjamin Mahler |
Re: Review Request 64493: Added tests for quota enforcement with unallocated reservations. |
Wed, 13 Dec, 20:31 |
| Benjamin Mahler |
Re: Review Request 64467: Rewrote the quota headroom enforcement logic in the allocator. |
Wed, 13 Dec, 21:08 |
| Benjamin Bannier |
Re: Review Request 64557: Handled the RP disconnection case in the agent. |
Wed, 13 Dec, 21:13 |
| Benjamin Bannier |
Re: Review Request 64574: Ensured trailing '/' in URL is insignificant. |
Wed, 13 Dec, 22:07 |
| Meng Zhu |
Re: Review Request 64467: Rewrote the quota headroom enforcement logic in the allocator. |
Wed, 13 Dec, 22:09 |
| Akash Gupta |
Review Request 64570: Windows: Temporarily fixed the docker executor. |
Wed, 13 Dec, 22:21 |
| Chun-Hung Hsiao |
Review Request 64583: Supporting pre-existing volumes with no profile in SLRP. |
Wed, 13 Dec, 22:49 |
| Jie Yu |
Re: Review Request 64559: Checkpointing `OfferOperation` in resource provider states. |
Wed, 13 Dec, 22:51 |
| Chun-Hung Hsiao |
Review Request 64584: Add a unit test for pre-existing volume support in SLRP. |
Wed, 13 Dec, 22:51 |
| Chun-Hung Hsiao |
Re: Review Request 64559: Checkpointing `OfferOperation` in resource provider states. |
Wed, 13 Dec, 23:22 |
| Chun-Hung Hsiao |
Re: Review Request 64551: Integrated the status update manager into SLRP. |
Wed, 13 Dec, 23:55 |
| Jie Yu |
Re: Review Request 64551: Integrated the status update manager into SLRP. |
Thu, 14 Dec, 00:15 |
| Jie Yu |
Re: Review Request 64581: Added `--volumes` flag for test CSI plugin to test pre-existing volumes. |
Thu, 14 Dec, 00:19 |
| Greg Mann |
Re: Review Request 64521: Made `StatusUpdateManagerProcess` fill in the latest status update. |
Thu, 14 Dec, 01:05 |
| Chun-Hung Hsiao |
Re: Review Request 64551: Integrated the status update manager into SLRP. |
Thu, 14 Dec, 01:18 |
| Chun-Hung Hsiao |
Review Request 64587: Printed fatal messages in lambdas where errors happen in SLRP. |
Thu, 14 Dec, 01:19 |
| Chun-Hung Hsiao |
Re: Review Request 64581: Added `--volumes` flag for test CSI plugin to test pre-existing volumes. |
Thu, 14 Dec, 01:20 |
| Greg Mann |
Re: Review Request 64505: Made the agent check for offer operation update retries. |
Thu, 14 Dec, 01:31 |
| Jie Yu |
Review Request 64589: Fixed a bug related to offer operation application in the agent. |
Thu, 14 Dec, 01:38 |
| Jie Yu |
Re: Review Request 64505: Made the agent check for offer operation update retries. |
Thu, 14 Dec, 01:42 |
| Chun-Hung Hsiao |
Review Request 64591: Printed out the source profile and ID for a disk resource. |
Thu, 14 Dec, 01:55 |
| Gaston Kleiman |
Review Request 64590: Stopped logging `operation_id` unconditionally in agent handler. |
Thu, 14 Dec, 01:55 |
| Gaston Kleiman |
Review Request 64588: Made the agent forward status updates for unknown offer operations. |
Thu, 14 Dec, 01:55 |
| Jie Yu |
Re: Review Request 64556: Made master acknowledge unknown operations during agent reconciliation. |
Thu, 14 Dec, 01:58 |
| Chun-Hung Hsiao |
Review Request 64593: Disabled `SlaveTest.ResourceProviderPublishAll` on Windows. |
Thu, 14 Dec, 02:46 |
| Jie Yu |
Re: Review Request 64581: Added `--volumes` flag for test CSI plugin to test pre-existing volumes. |
Thu, 14 Dec, 02:56 |
| Benjamin Mahler |
Re: Review Request 64467: Rewrote the quota headroom enforcement logic in the allocator. |
Thu, 14 Dec, 04:21 |
| Jie Yu |
Re: Review Request 64583: Supporting pre-existing volumes with no profile in SLRP. |
Thu, 14 Dec, 04:45 |
| Jie Yu |
Re: Review Request 64584: Add a unit test for pre-existing volume support in SLRP. |
Thu, 14 Dec, 04:47 |
| Jie Yu |
Re: Review Request 64587: Printed fatal messages in lambdas where errors happen in SLRP. |
Thu, 14 Dec, 04:47 |
| Jie Yu |
Re: Review Request 64588: Made the agent forward status updates for unknown offer operations. |
Thu, 14 Dec, 05:00 |
| Jie Yu |
Re: Review Request 64590: Stopped logging `operation_id` unconditionally in agent handler. |
Thu, 14 Dec, 05:14 |
| Chun-Hung Hsiao |
Re: Review Request 64589: Fixed a bug related to offer operation application in the agent. |
Thu, 14 Dec, 05:33 |
| Chun-Hung Hsiao |
Re: Review Request 63971: Defined a module interface for translating volume profiles. |
Thu, 14 Dec, 06:35 |
| Benjamin Bannier |
Re: Review Request 64589: Fixed a bug related to offer operation application in the agent. |
Thu, 14 Dec, 08:35 |
| Benjamin Bannier |
Review Request 64599: Removed unused import in proto file. |
Thu, 14 Dec, 09:16 |
| Benjamin Bannier |
Re: Review Request 64546: Fixed a flaky test. |
Thu, 14 Dec, 09:29 |
| Jan Schlicht |
Re: Review Request 64381: Mesos: Used a namespace for UUID. |
Thu, 14 Dec, 09:50 |
| Jan Schlicht |
Re: Review Request 64168: Introduced a 'UUID' type. |
Thu, 14 Dec, 09:51 |
| Benjamin Bannier |
Review Request 64600: Fixed handling of resource provider updates without resources. |
Thu, 14 Dec, 10:01 |
| Benjamin Bannier |
Re: Review Request 64574: Ensured trailing '/' in URL is insignificant. |
Thu, 14 Dec, 10:06 |
| Benjamin Bannier |
Re: Review Request 64574: Ensured trailing '/' in URL is insignificant. |
Thu, 14 Dec, 10:06 |
| Mesos Reviewbot Windows |
Re: Review Request 64379: Improved logs displayed after a slave failed recovery. |
Thu, 14 Dec, 10:34 |
| Jan Schlicht |
Re: Review Request 64546: Fixed a flaky test. |
Thu, 14 Dec, 10:35 |
| Mesos Reviewbot Windows |
Re: Review Request 64522: WIP: try to make tests pass on Windows. |
Thu, 14 Dec, 11:25 |
| Akash Gupta |
Review Request 64604: Windows: Updated heath-checks.md with Windows implementation. |
Thu, 14 Dec, 11:58 |
| Benjamin Bannier |
Review Request 64603: Fixed style violations regarding whitespace around operators. |
Thu, 14 Dec, 12:00 |
| Akash Gupta |
Re: Review Request 64387: Windows: Ported docker health check tests. |
Thu, 14 Dec, 12:00 |
| Alexander Rukletsov |
Re: Review Request 64603: Fixed style violations regarding whitespace around operators. |
Thu, 14 Dec, 12:01 |
| Akash Gupta |
Re: Review Request 64386: Windows: Enabled docker health checks. |
Thu, 14 Dec, 12:09 |
| Mesos Reviewbot Windows |
Re: Review Request 64590: Stopped logging `operation_id` unconditionally in agent handler. |
Thu, 14 Dec, 12:14 |
| Mesos Reviewbot Windows |
Re: Review Request 64589: Fixed a bug related to offer operation application in the agent. |
Thu, 14 Dec, 13:05 |
| Joseph Wu |
Review Request 64612: Added flag to pass VolumeProfileAdaptor module to SLRP. |
Thu, 14 Dec, 13:15 |
| Joseph Wu |
Review Request 64615: Moved SLRP resource recovery logic into a helper. |
Thu, 14 Dec, 13:34 |
| Joseph Wu |
Review Request 64616: WIP: Modified SLRP to use the VolumeProfileAdaptor module. |
Thu, 14 Dec, 13:36 |
| Jan Schlicht |
Re: Review Request 64168: Introduced a 'UUID' type. |
Thu, 14 Dec, 13:56 |
| Mesos Reviewbot Windows |
Re: Review Request 64546: Fixed a flaky test. |
Thu, 14 Dec, 13:57 |
| Benjamin Bannier |
Re: Review Request 64546: Fixed a flaky test. |
Thu, 14 Dec, 13:59 |
| Mesos Reviewbot Windows |
Re: Review Request 64599: Removed unused import in proto file. |
Thu, 14 Dec, 14:32 |
| Mesos Reviewbot Windows |
Re: Review Request 64168: Introduced a 'UUID' type. |
Thu, 14 Dec, 15:17 |
| Benno Evers |
Re: Review Request 64506: Correctly reset slave status when aborting a registration. |
Thu, 14 Dec, 15:32 |
| Mesos Reviewbot Windows |
Re: Review Request 64600: Fixed handling of resource provider updates without resources. |
Thu, 14 Dec, 16:02 |
| Gilbert Song |
Re: Review Request 62876: Fix compile error for bundled gRPC on Debian 8 with libc-ares-dev. |
Thu, 14 Dec, 16:30 |
| Mesos Reviewbot Windows |
Re: Review Request 64616: WIP: Modified SLRP to use the VolumeProfileAdaptor module. |
Thu, 14 Dec, 16:30 |
| Chun-Hung Hsiao |
Re: Review Request 64589: Fixed a bug related to offer operation application in the agent. |
Thu, 14 Dec, 16:33 |
| Benjamin Bannier |
Re: Review Request 64168: Introduced a 'UUID' type. |
Thu, 14 Dec, 16:38 |
| Mesos Reviewbot Windows |
Re: Review Request 64604: Windows: Updated heath-checks.md with Windows implementation. |
Thu, 14 Dec, 16:54 |
| Chun-Hung Hsiao |
Re: Review Request 64599: Removed unused import in proto file. |
Thu, 14 Dec, 17:14 |
| Jie Yu |
Re: Review Request 64589: Fixed a bug related to offer operation application in the agent. |
Thu, 14 Dec, 17:20 |
| Jie Yu |
Re: Review Request 64589: Fixed a bug related to offer operation application in the agent. |
Thu, 14 Dec, 17:20 |
| Greg Mann |
Re: Review Request 64590: Stopped logging `operation_id` unconditionally in agent handler. |
Thu, 14 Dec, 17:55 |
| Greg Mann |
Re: Review Request 64556: Made master acknowledge unknown operations during agent reconciliation. |
Thu, 14 Dec, 18:00 |
| Gaston Kleiman |
Re: Review Request 64590: Stopped logging optional fields unconditionally in agent handler. |
Thu, 14 Dec, 18:22 |
| Gaston Kleiman |
Review Request 64618: Implemented the master's ACKNOWLEDGE_OFFER_OPERATION_UPDATE handler. |
Thu, 14 Dec, 18:27 |
| Mesos Reviewbot Windows |
Re: Review Request 64618: Implemented the master's ACKNOWLEDGE_OFFER_OPERATION_UPDATE handler. |
Thu, 14 Dec, 18:53 |
| Mesos Reviewbot Windows |
Re: Review Request 64590: Stopped logging optional fields unconditionally in agent handler. |
Thu, 14 Dec, 18:55 |
| James Peach |
Review Request 64620: Fixed `os::chown` error message. |
Thu, 14 Dec, 18:58 |
| Andrew Schwartzmeyer |
Re: Review Request 64620: Fixed `os::chown` error message. |
Thu, 14 Dec, 19:02 |
| Andrew Schwartzmeyer |
Re: Review Request 64461: Windows: Added legacy support for admin-only symlinks. |
Thu, 14 Dec, 19:23 |
| Chun-Hung Hsiao |
Review Request 64621: Fixed a corner case for pre-existing volumes created by old RPs. |
Thu, 14 Dec, 19:34 |
| Andrew Schwartzmeyer |
Re: Review Request 64461: Windows: Added legacy support for admin-only symlinks. |
Thu, 14 Dec, 19:35 |
| James Peach |
Re: Review Request 64461: Windows: Added legacy support for admin-only symlinks. |
Thu, 14 Dec, 19:46 |
| Mesos Reviewbot Windows |
Re: Review Request 64620: Fixed `os::chown` error message. |
Thu, 14 Dec, 19:47 |
| Mesos Reviewbot Windows |
Re: Review Request 64522: WIP: try to make tests pass on Windows. |
Thu, 14 Dec, 19:48 |
| Jie Yu |
Review Request 64623: Fixed a bug in handling standalone container recovery. |
Thu, 14 Dec, 20:14 |
| Jie Yu |
Review Request 64624: Added standalone isolator capability. |
Thu, 14 Dec, 20:15 |
| Jie Yu |
Re: Review Request 64624: Added standalone isolator capability. |
Thu, 14 Dec, 20:19 |
| Mesos Reviewbot Windows |
Re: Review Request 64461: Windows: Added legacy support for admin-only symlinks. |
Thu, 14 Dec, 20:37 |
| Andrew Schwartzmeyer |
Re: Review Request 64461: Windows: Added legacy support for admin-only symlinks. |
Thu, 14 Dec, 20:38 |
| Mesos Reviewbot Windows |
Re: Review Request 64621: Fixed a corner case for pre-existing volumes created by old RPs. |
Thu, 14 Dec, 20:42 |
| Andrew Schwartzmeyer |
Re: Review Request 64461: Windows: Added legacy support for admin-only symlinks. |
Thu, 14 Dec, 20:43 |
| James Peach |
Re: Review Request 64461: Windows: Added legacy support for admin-only symlinks. |
Thu, 14 Dec, 21:17 |
| Mesos Reviewbot Windows |
Re: Review Request 64461: Windows: Added legacy support for admin-only symlinks. |
Thu, 14 Dec, 21:37 |
| Benjamin Mahler |
Re: Review Request 64506: Correctly reset slave status when aborting a registration. |
Thu, 14 Dec, 21:37 |
| Benjamin Mahler |
Re: Review Request 64574: Ensured trailing '/' in URL is insignificant. |
Thu, 14 Dec, 21:40 |
| Mesos Reviewbot Windows |
Re: Review Request 64624: Added standalone isolator capability. |
Thu, 14 Dec, 21:41 |
| Chun-Hung Hsiao |
Review Request 64627: Fixed unit error and clang compile error for SLRP and its tests. |
Thu, 14 Dec, 22:24 |
| Ilya Pronin |
Review Request 64626: Prototype: Added LIBPROCESS_LOCAL_MESSAGE_PASSING option. |
Thu, 14 Dec, 22:27 |
| Mesos Reviewbot Windows |
Re: Review Request 64627: Fixed unit error and clang compile error for SLRP and its tests. |
Thu, 14 Dec, 22:30 |
| Gaston Kleiman |
Re: Review Request 64522: WIP: try to make tests pass on Windows. |
Thu, 14 Dec, 22:31 |