| Benno Evers |
Re: Review Request 64011: Updated master behaviour to update agent state on reregistration. |
Mon, 04 Dec, 16:30 |
| Benno Evers |
Re: Review Request 64012: Added new --reconfiguration_compatibility slave flag and implementation. |
Mon, 04 Dec, 16:33 |
| Chun-Hung Hsiao |
Re: Review Request 63389: Added a mock resource provider manager. |
Mon, 04 Dec, 16:38 |
| Benno Evers |
Review Request 64306: Rename reconfiguration_compatibility to reconfiguration_policy. |
Mon, 04 Dec, 17:01 |
| Jie Yu |
Re: Review Request 64294: Renamed `ACKNOWLEDGE_PUBLISH` to `UPDATE_PUBLISH_STATUS`. |
Mon, 04 Dec, 17:04 |
| Jie Yu |
Re: Review Request 63386: Added utility functions for resource provider API. |
Mon, 04 Dec, 17:13 |
| Michael Park |
Re: Review Request 63630: Added support for callable once functors. |
Mon, 04 Dec, 17:15 |
| Benno Evers |
Review Request 64307: Rename reconfiguration_compatibility to reconfiguration_policy. |
Mon, 04 Dec, 17:19 |
| Alexander Rukletsov |
Re: Review Request 64033: Terminated driver-based executors if kill arrives before launch task. |
Mon, 04 Dec, 17:44 |
| Andrew Schwartzmeyer |
Re: Review Request 64272: Improved Windows isolators with `struct Info` abstraction. |
Mon, 04 Dec, 17:53 |
| Michael Park |
Re: Review Request 63914: Changed agent reregistration to work with message directly. |
Mon, 04 Dec, 17:57 |
| Alexander Rukletsov |
Re: Review Request 64033: Terminated driver-based executors if kill arrives before launch task. |
Mon, 04 Dec, 18:02 |
| Alexander Rukletsov |
Re: Review Request 64032: Promoted log level to warning for disconnected events in exec.cpp. |
Mon, 04 Dec, 18:03 |
| Dmitry Zhuk |
Re: Review Request 64274: Added `lambda::partial` to <stout/lambda.hpp>. |
Mon, 04 Dec, 18:18 |
| Gilbert Song |
Re: Review Request 64265: Added a flag conversion protobuf message 'ImageGcConfig'. |
Mon, 04 Dec, 18:35 |
| Gilbert Song |
Re: Review Request 64265: Added a flag conversion protobuf message 'ImageGcConfig'. |
Mon, 04 Dec, 18:35 |
| Andrew Schwartzmeyer |
Re: Review Request 64104: Added dependency of curl to agent. Enabled most health check tests. |
Mon, 04 Dec, 18:35 |
| Jiang Yan Xu |
Re: Review Request 64098: Send status updates when agent re-registers. |
Mon, 04 Dec, 18:43 |
| Ilya Pronin |
Re: Review Request 64098: Send status updates when agent re-registers. |
Mon, 04 Dec, 18:51 |
| John Kordich via Review Board |
Re: Review Request 64102: Renamed curl target to libcurl, and staging of curl.exe on Windows. |
Mon, 04 Dec, 18:54 |
| John Kordich via Review Board |
Re: Review Request 64103: Changed dependency of curl to libcurl for stout. |
Mon, 04 Dec, 18:54 |
| John Kordich via Review Board |
Re: Review Request 64104: Added dependency of curl to agent. Enabled most health check tests. |
Mon, 04 Dec, 18:54 |
| Gaston Kleiman |
Re: Review Request 64096: Implemented the `OfferOperationStatusUpdateManager`. |
Mon, 04 Dec, 18:56 |
| Jie Yu |
Re: Review Request 63498: Allowed relative path in `Resource.disk.source.{path, mount}.root. |
Mon, 04 Dec, 19:13 |
| Gilbert Song |
Re: Review Request 64267: Supported basic auto image gc in the agent. |
Mon, 04 Dec, 19:20 |
| Gilbert Song |
Re: Review Request 64267: Supported basic auto image gc in the agent. |
Mon, 04 Dec, 19:22 |
| Michael Park |
Review Request 64312: Added reservation refinement documentation. |
Mon, 04 Dec, 19:32 |
| Michael Park |
Re: Review Request 63634: Changed dispatch to use callable once functors. |
Mon, 04 Dec, 19:36 |
| Michael Park |
Re: Review Request 63915: Reduced tasks copying during agent reregistration. |
Mon, 04 Dec, 19:37 |
| Greg Mann |
Review Request 64313: Removed the 'id' field from 'Offer::Operation'. |
Mon, 04 Dec, 20:04 |
| Jie Yu |
Re: Review Request 64272: Improved Windows isolators with `struct Info` abstraction. |
Mon, 04 Dec, 20:06 |
| Greg Mann |
Re: Review Request 64093: Added operators for offer operation update protobuf classes. |
Mon, 04 Dec, 20:19 |
| Benjamin Mahler |
Re: Review Request 63492: Synchronized agent resource versions via 'UpdateSlaveMessage'. |
Mon, 04 Dec, 21:03 |
| Mesos Reviewbot Windows |
Re: Review Request 64297: Updated modules documentation with some more details. |
Mon, 04 Dec, 21:08 |
| Mesos Reviewbot Windows |
Re: Review Request 63389: Added a mock resource provider manager. |
Mon, 04 Dec, 21:09 |
| Benjamin Mahler |
Re: Review Request 63914: Changed agent reregistration to work with message directly. |
Mon, 04 Dec, 21:18 |
| Andrew Schwartzmeyer |
Re: Review Request 63340: Moved Java build code to `java/CMakeLists.txt`. |
Mon, 04 Dec, 21:19 |
| Andrew Schwartzmeyer |
Re: Review Request 63341: Set `BUILD_FLAGS` flag in CMake. |
Mon, 04 Dec, 21:19 |
| Andrew Schwartzmeyer |
Re: Review Request 63342: Fixed CMake binary dependencies. |
Mon, 04 Dec, 21:19 |
| Mesos Reviewbot Windows |
Re: Review Request 64307: Rename reconfiguration_compatibility to reconfiguration_policy. |
Mon, 04 Dec, 21:20 |
| Benjamin Mahler |
Re: Review Request 63915: Reduced tasks copying during agent reregistration. |
Mon, 04 Dec, 21:22 |
| Joseph Wu |
Re: Review Request 63340: Moved Java build code to `java/CMakeLists.txt`. |
Mon, 04 Dec, 21:26 |
| Andrew Schwartzmeyer |
Re: Review Request 63340: Moved Java build code to `java/CMakeLists.txt`. |
Mon, 04 Dec, 21:27 |
| Joseph Wu |
Re: Review Request 63341: Set `BUILD_FLAGS` flag in CMake. |
Mon, 04 Dec, 21:31 |
| Benjamin Bannier |
Re: Review Request 63341: Set `BUILD_FLAGS` flag in CMake. |
Mon, 04 Dec, 21:36 |
| Vinod Kone |
Re: Review Request 64010: Added `SlaveInfo` parameter to Allocator::updateSlave(). |
Mon, 04 Dec, 21:36 |
| Andrew Schwartzmeyer |
Re: Review Request 63341: Set `BUILD_FLAGS` flag in CMake. |
Mon, 04 Dec, 21:38 |
| Joseph Wu |
Re: Review Request 63341: Set `BUILD_FLAGS` flag in CMake. |
Mon, 04 Dec, 21:39 |
| Benjamin Mahler |
Re: Review Request 64238: Updated the allocator to track allocations via a single code path. |
Mon, 04 Dec, 21:41 |
| Joseph Wu |
Re: Review Request 63342: Fixed CMake binary dependencies. |
Mon, 04 Dec, 21:43 |
| Meng Zhu |
Re: Review Request 64304: Enforced quota limit in the presence of unallocated reservations. |
Mon, 04 Dec, 21:48 |
| Benjamin Bannier |
Re: Review Request 64238: Updated the allocator to track allocations via a single code path. |
Mon, 04 Dec, 21:55 |
| Greg Mann |
Re: Review Request 64146: Added offer operation update acknowledgement to the agent. |
Mon, 04 Dec, 21:57 |
| Michael Park |
Re: Review Request 64312: Added reservation refinement documentation. |
Mon, 04 Dec, 21:58 |
| Vinod Kone |
Re: Review Request 64011: Updated master behaviour to update agent state on reregistration. |
Mon, 04 Dec, 22:05 |
| Benjamin Mahler |
Re: Review Request 64312: Added reservation refinement documentation. |
Mon, 04 Dec, 22:08 |
| Greg Mann |
Re: Review Request 64142: Updated master ACCEPT handler to disallow offer operation feedback. |
Mon, 04 Dec, 22:08 |
| Greg Mann |
Re: Review Request 64144: Made master acknowledge offer operation updates when 'id' isn't set. |
Mon, 04 Dec, 22:22 |
| Greg Mann |
Re: Review Request 64144: Made master acknowledge offer operation updates when 'id' isn't set. |
Mon, 04 Dec, 22:23 |
| Greg Mann |
Re: Review Request 64143: Added ACKNOWLEDGE event to the resource provider API. |
Mon, 04 Dec, 22:24 |
| Greg Mann |
Re: Review Request 64146: Added offer operation update acknowledgement to the agent. |
Mon, 04 Dec, 22:24 |
| Benjamin Mahler |
Re: Review Request 64238: Updated the allocator to track allocations via a single code path. |
Mon, 04 Dec, 22:32 |
| Michael Park |
Re: Review Request 64312: Added reservation refinement documentation. |
Mon, 04 Dec, 22:39 |
| Zhitao Li |
Re: Review Request 64265: Added a flag conversion protobuf message 'ImageGcConfig'. |
Mon, 04 Dec, 22:49 |
| Gaston Kleiman |
Re: Review Request 64096: Implemented the `OfferOperationStatusUpdateManager`. |
Mon, 04 Dec, 23:08 |
| Vinod Kone |
Re: Review Request 64012: Added new --reconfiguration_compatibility slave flag and implementation. |
Mon, 04 Dec, 23:14 |
| Meng Zhu |
Re: Review Request 64303: Tracked resource reservations in the allocator. |
Mon, 04 Dec, 23:18 |
| Meng Zhu |
Re: Review Request 64304: Enforced quota limit in the presence of unallocated reservations. |
Mon, 04 Dec, 23:18 |
| Benno Evers |
Re: Review Request 64010: Added `SlaveInfo` parameter to Allocator::updateSlave(). |
Mon, 04 Dec, 23:30 |
| Benno Evers |
Re: Review Request 64011: Updated master behaviour to update agent state on reregistration. |
Mon, 04 Dec, 23:31 |
| Benno Evers |
Re: Review Request 64011: Updated master behaviour to update agent state on reregistration. |
Mon, 04 Dec, 23:43 |
| Vinod Kone |
Re: Review Request 64101: Skip registry update when nothing changed. |
Mon, 04 Dec, 23:45 |
| Andrew Schwartzmeyer |
Re: Review Request 63340: Moved Java build code to `java/CMakeLists.txt`. |
Tue, 05 Dec, 00:13 |
| Mesos Reviewbot Windows |
Re: Review Request 64098: Send status updates when agent re-registers. |
Tue, 05 Dec, 00:16 |
| Chun-Hung Hsiao |
Re: Review Request 63498: Allowed relative path in `Resource.disk.source.{path, mount}.root. |
Tue, 05 Dec, 00:45 |
| Benjamin Mahler |
Re: Review Request 64248: Added `cpp17::invoke` in <stout/cpp17.hpp>. |
Tue, 05 Dec, 01:07 |
| Benjamin Mahler |
Re: Review Request 64304: Enforced quota limit in the presence of unallocated reservations. |
Tue, 05 Dec, 01:08 |
| Mesos Reviewbot Windows |
Re: Review Request 64104: Added dependency of curl to agent. Enabled most health check tests. |
Tue, 05 Dec, 01:11 |
| Jie Yu |
Re: Review Request 64158: Used helper functions instead of switches for resource extraction. |
Tue, 05 Dec, 01:26 |
| Meng Zhu |
Review Request 64319: Clarified a comment. |
Tue, 05 Dec, 01:35 |
| Chun-Hung Hsiao |
Review Request 64320: Fixed the code to track resources under roles for offer operations. |
Tue, 05 Dec, 01:46 |
| Benjamin Mahler |
Re: Review Request 64319: Clarified a comment. |
Tue, 05 Dec, 01:49 |
| Benjamin Mahler |
Re: Review Request 64319: Clarified a comment. |
Tue, 05 Dec, 01:49 |
| Jie Yu |
Re: Review Request 63023: Added a test CSI plugin. |
Tue, 05 Dec, 02:12 |
| Anand Mazumdar |
Re: Review Request 64033: Terminated driver-based executors if kill arrives before launch task. |
Tue, 05 Dec, 02:17 |
| Jie Yu |
Re: Review Request 64320: Fixed the code to track resources under roles for offer operations. |
Tue, 05 Dec, 02:18 |
| Chun-Hung Hsiao |
Re: Review Request 63022: Imported and reconcile resources from CSI plugins. |
Tue, 05 Dec, 02:18 |
| Chun-Hung Hsiao |
Re: Review Request 63387: Added publish/unpublish in storage local resource provider. |
Tue, 05 Dec, 02:19 |
| Chun-Hung Hsiao |
Re: Review Request 63388: Handling offer operations in storage local resource provider. |
Tue, 05 Dec, 02:19 |
| Meng Zhu |
Review Request 64321: Fixed an allocator test. |
Tue, 05 Dec, 02:27 |
| Chun-Hung Hsiao |
Review Request 64322: Fixed resources tracking under roles when removing offer operations. |
Tue, 05 Dec, 02:29 |
| Benjamin Mahler |
Re: Review Request 64321: Fixed an allocator test. |
Tue, 05 Dec, 03:24 |
| Jie Yu |
Re: Review Request 63498: Allowed relative path in `Resource.disk.source.{path, mount}.root. |
Tue, 05 Dec, 03:35 |
| Jie Yu |
Re: Review Request 63022: Imported and reconcile resources from CSI plugins. |
Tue, 05 Dec, 03:45 |
| Mesos Reviewbot Windows |
Re: Review Request 63915: Reduced tasks copying during agent reregistration. |
Tue, 05 Dec, 05:13 |
| Chun-Hung Hsiao |
Re: Review Request 63022: Imported and reconcile resources from CSI plugins. |
Tue, 05 Dec, 05:57 |
| Chun-Hung Hsiao |
Re: Review Request 63387: Added publish/unpublish in storage local resource provider. |
Tue, 05 Dec, 05:59 |
| Chun-Hung Hsiao |
Re: Review Request 63390: Create/destroy volume test for storage local resource provider. |
Tue, 05 Dec, 06:00 |
| Megha Sharma |
Re: Review Request 64098: Send status updates when agent re-registers. |
Tue, 05 Dec, 06:02 |
| Megha Sharma |
Re: Review Request 64098: Send status updates when agent re-registers. |
Tue, 05 Dec, 06:04 |