| Chun-Hung Hsiao |
Review Request 64754: Made helper functions of `Bytes` return a double value. |
Wed, 20 Dec, 22:14 |
| Chun-Hung Hsiao |
Review Request 64755: Adjusted the usage of `Bytes::kilobytes()` and `Bytes::megabytes()`. |
Wed, 20 Dec, 22:14 |
| Chun-Hung Hsiao |
Review Request 64756: Fixed a bug that SLRP would fail if the state files do not exist. |
Wed, 20 Dec, 22:14 |
| Benjamin Mahler |
Re: Review Request 64754: Made helper functions of `Bytes` return a double value. |
Wed, 20 Dec, 22:25 |
| Chun-Hung Hsiao |
Re: Review Request 64754: Made helper functions of `Bytes` return a double value. |
Wed, 20 Dec, 23:13 |
| Mesos Reviewbot Windows |
Re: Review Request 64756: Fixed a bug that SLRP would fail if the state files do not exist. |
Wed, 20 Dec, 23:13 |
| Meng Zhu |
Re: Review Request 64741: Eliminated some unnecessary copying in the HTTP operator API. |
Thu, 21 Dec, 00:37 |
| Meng Zhu |
Review Request 64760: Fixed a few comment typos in the `hierarchical.cpp`. |
Thu, 21 Dec, 00:50 |
| Benjamin Mahler |
Re: Review Request 64003: Made quota resource allocation fine-grained. |
Thu, 21 Dec, 01:06 |
| Meng Zhu |
Review Request 64761: Moved the quota headroom tracking before quota allocation. |
Thu, 21 Dec, 01:11 |
| Benjamin Mahler |
Re: Review Request 64003: Made quota resource allocation fine-grained. |
Thu, 21 Dec, 01:16 |
| Benjamin Mahler |
Re: Review Request 64741: Eliminated some unnecessary copying in the HTTP operator API. |
Thu, 21 Dec, 01:33 |
| James Peach |
Re: Review Request 64743: Enabled function sections. |
Thu, 21 Dec, 01:47 |
| Benjamin Mahler |
Re: Review Request 64758: Added a test to ensure MOUNT disk resource is allocated exclusively. |
Thu, 21 Dec, 01:48 |
| Benjamin Mahler |
Re: Review Request 64761: Moved the quota headroom tracking before quota allocation. |
Thu, 21 Dec, 01:57 |
| Mesos Reviewbot Windows |
Re: Review Request 64760: Fixed a few comment typos in the `hierarchical.cpp`. |
Thu, 21 Dec, 01:58 |
| Mesos Reviewbot Windows |
Re: Review Request 64761: Moved the quota headroom tracking before quota allocation. |
Thu, 21 Dec, 02:00 |
| James Peach |
Re: Review Request 64743: Enabled function sections. |
Thu, 21 Dec, 02:02 |
| Qian Zhang |
Re: Review Request 59987: Added protobuf map support. |
Thu, 21 Dec, 02:07 |
| Benjamin Mahler |
Re: Review Request 63976: Modified `downgradeResources` to use protobuf reflection. |
Thu, 21 Dec, 02:24 |
| Gaston Kleiman |
Review Request 64762: Renamed offer operation to operation. |
Thu, 21 Dec, 02:25 |
| Meng Zhu |
Re: Review Request 64003: Made quota resource allocation fine-grained. |
Thu, 21 Dec, 02:25 |
| Meng Zhu |
Re: Review Request 64761: Moved the quota headroom tracking before quota allocation. |
Thu, 21 Dec, 02:39 |
| Benjamin Mahler |
Re: Review Request 64003: Made quota resource allocation fine-grained. |
Thu, 21 Dec, 02:47 |
| Meng Zhu |
Re: Review Request 64758: Added a test to ensure MOUNT disk is not chopped during allocation. |
Thu, 21 Dec, 02:48 |
| Benjamin Mahler |
Re: Review Request 64758: Added a test to ensure MOUNT disk is not chopped during allocation. |
Thu, 21 Dec, 02:51 |
| Mesos Reviewbot Windows |
Re: Review Request 64743: Enabled function sections. |
Thu, 21 Dec, 02:53 |
| Benjamin Mahler |
Re: Review Request 64760: Fixed a few comment typos in the `hierarchical.cpp`. |
Thu, 21 Dec, 03:10 |
| Chun-Hung Hsiao |
Re: Review Request 64754: Removed `kilobytes()`, `megabytes()`, etc from `Bytes`. |
Thu, 21 Dec, 03:41 |
| Chun-Hung Hsiao |
Re: Review Request 64755: Removed the usage of `Bytes::kilobytes()` and `Bytes::megabytes()`. |
Thu, 21 Dec, 03:41 |
| Chun-Hung Hsiao |
Review Request 64763: Fixed compilation for python eggs when gRPC is enabled. |
Thu, 21 Dec, 03:41 |
| Benjamin Mahler |
Review Request 64765: Removed a stale TODO in the allocator. |
Thu, 21 Dec, 03:49 |
| Mesos Reviewbot Windows |
Re: Review Request 64762: Renamed offer operation to operation. |
Thu, 21 Dec, 03:53 |
| Mesos Reviewbot Windows |
Re: Review Request 64765: Removed a stale TODO in the allocator. |
Thu, 21 Dec, 04:21 |
| Mesos Reviewbot Windows |
Re: Review Request 64763: Fixed compilation for python eggs when gRPC is enabled. |
Thu, 21 Dec, 04:53 |
| Jie Yu |
Re: Review Request 64762: Renamed offer operation to operation. |
Thu, 21 Dec, 05:44 |
| Benjamin Bannier |
Re: Review Request 64713: Fixed a crash when resubscribing resource providers. |
Thu, 21 Dec, 09:14 |
| Mesos Reviewbot Windows |
Re: Review Request 64683: Updated support/mesos-style.py to build the virtualenv less often. |
Thu, 21 Dec, 11:53 |
| Alexander Rukletsov |
Re: Review Request 64033: Terminated driver-based executors if kill arrives before launch task. |
Thu, 21 Dec, 13:52 |
| Mesos Reviewbot Windows |
Re: Review Request 64647: Updated tests related to containerizer refactoring. |
Thu, 21 Dec, 14:03 |
| Till Toenshoff |
Re: Review Request 64683: Updated support/mesos-style.py to build the virtualenv less often. |
Thu, 21 Dec, 14:17 |
| Andrei Budnik |
Re: Review Request 64033: Terminated driver-based executors if kill arrives before launch task. |
Thu, 21 Dec, 14:24 |
| Andrei Budnik |
Re: Review Request 64069: Ensured command executor always honors shutdown request. |
Thu, 21 Dec, 14:34 |
| Andrei Budnik |
Review Request 64770: Fixed a potential race condition in the test infrastructure. |
Thu, 21 Dec, 14:57 |
| Andrei Budnik |
Re: Review Request 64070: Ensured executor adapter propagates error and shutdown messages. |
Thu, 21 Dec, 15:03 |
| Andrei Budnik |
Re: Review Request 64070: Ensured executor adapter propagates error and shutdown messages. |
Thu, 21 Dec, 15:03 |
| Benno Evers |
Re: Review Request 64683: Updated support/mesos-style.py to build the virtualenv less often. |
Thu, 21 Dec, 15:15 |
| Alexander Rukletsov |
Re: Review Request 64070: Ensured executor adapter propagates error and shutdown messages. |
Thu, 21 Dec, 15:40 |
| Mesos Reviewbot Windows |
Re: Review Request 64770: Fixed a potential race condition in the test infrastructure. |
Thu, 21 Dec, 15:53 |
| Benno Evers |
Review Request 64777: Modified the autotools build for multiple patch files. |
Thu, 21 Dec, 15:56 |
| Benno Evers |
Review Request 64778: Display time zone in log messages. |
Thu, 21 Dec, 15:56 |
| Andrei Budnik |
Re: Review Request 64770: Fixed a potential race condition in the test infrastructure. |
Thu, 21 Dec, 15:58 |
| Alexander Rukletsov |
Re: Review Request 64070: Ensured executor adapter propagates error and shutdown messages. |
Thu, 21 Dec, 16:07 |
| Jie Yu |
Re: Review Request 64754: Removed `kilobytes()`, `megabytes()`, etc from `Bytes`. |
Thu, 21 Dec, 16:31 |
| Mesos Reviewbot Windows |
Re: Review Request 64778: Display time zone in log messages. |
Thu, 21 Dec, 16:53 |
| Jie Yu |
Re: Review Request 64755: Removed the usage of `Bytes::kilobytes()` and `Bytes::megabytes()`. |
Thu, 21 Dec, 17:51 |
| Mesos Reviewbot Windows |
Re: Review Request 64770: Fixed a potential race condition in the test infrastructure. |
Thu, 21 Dec, 17:54 |
| Jie Yu |
Re: Review Request 64756: Fixed a bug that SLRP would fail if the state files do not exist. |
Thu, 21 Dec, 18:15 |
| Jie Yu |
Re: Review Request 64763: Fixed compilation for python eggs when gRPC is enabled. |
Thu, 21 Dec, 18:26 |
| Chun-Hung Hsiao |
Re: Review Request 64755: Removed the usage of `Bytes::kilobytes()` and `Bytes::megabytes()`. |
Thu, 21 Dec, 19:01 |
| Alexander Rukletsov |
Re: Review Request 64686: Fixed the type-punned pointer and strict aliasing issue. |
Thu, 21 Dec, 19:42 |
| Benjamin Bannier |
Re: Review Request 64686: Fixed the type-punned pointer and strict aliasing issue. |
Thu, 21 Dec, 20:00 |
| Mesos Reviewbot Windows |
Re: Review Request 64686: Fixed the type-punned pointer and strict aliasing issue. |
Thu, 21 Dec, 20:43 |
| Jie Yu |
Re: Review Request 62285: Added tombstone flag to NOP log action. |
Thu, 21 Dec, 21:50 |
| Jie Yu |
Re: Review Request 62760: Exposed runRecoverProtocol() function in recover.hpp. |
Thu, 21 Dec, 21:52 |
| Jie Yu |
Re: Review Request 62761: Moved retry logic from RecoverProtocolProcess to RecoverProcess. |
Thu, 21 Dec, 22:09 |
| Jie Yu |
Re: Review Request 62286: Added CatchupMissing log process. |
Thu, 21 Dec, 22:17 |
| Jie Yu |
Re: Review Request 62287: Added Log::Reader::catchup() method. |
Thu, 21 Dec, 22:19 |
| Jie Yu |
Re: Review Request 62288: Added Log.Reader.catchup() method to Java bindings. |
Thu, 21 Dec, 22:28 |
| Jie Yu |
Review Request 64790: Fixed a compile error due to string literals and macros. |
Thu, 21 Dec, 23:30 |
| Chun-Hung Hsiao |
Re: Review Request 64790: Fixed a compile error due to string literals and macros. |
Fri, 22 Dec, 00:03 |
| Mesos Reviewbot Windows |
Re: Review Request 64790: Fixed a compile error due to string literals and macros. |
Fri, 22 Dec, 00:35 |
| Meng Zhu |
Review Request 64792: Fixed a bug where quota headroom is tracked incorrectly. |
Fri, 22 Dec, 00:47 |
| Meng Zhu |
Review Request 64793: Fixed a bug where resource over allocation may break quota headroom. |
Fri, 22 Dec, 00:48 |
| Meng Zhu |
Review Request 64794: Added a test to verify the behavior of allocating resources w/o quota. |
Fri, 22 Dec, 00:48 |
| Benjamin Mahler |
Re: Review Request 64792: Fixed a bug where quota headroom is tracked incorrectly. |
Fri, 22 Dec, 01:27 |
| Mesos Reviewbot Windows |
Re: Review Request 64794: Added a test to verify the behavior of allocating resources w/o quota. |
Fri, 22 Dec, 02:27 |
| Benjamin Mahler |
Re: Review Request 64793: Fixed a bug where resource over allocation may break quota headroom. |
Fri, 22 Dec, 02:45 |
| Benjamin Mahler |
Re: Review Request 64794: Added a test to verify the behavior of allocating resources w/o quota. |
Fri, 22 Dec, 02:52 |
| Benjamin Mahler |
Re: Review Request 64739: Upgraded resources that come from `protobuf::read`. |
Fri, 22 Dec, 02:55 |
| Greg Mann |
Re: Review Request 64770: Fixed a potential race condition in the test infrastructure. |
Fri, 22 Dec, 03:38 |
| Meng Zhu |
Review Request 64798: Added an utility to shrink scalar resource while keeping its meta-data. |
Fri, 22 Dec, 04:08 |
| Meng Zhu |
Re: Review Request 64793: Fixed a bug where resource over allocation may break quota headroom. |
Fri, 22 Dec, 04:17 |
| Meng Zhu |
Re: Review Request 64794: Added a test to verify the behavior of allocating resources w/o quota. |
Fri, 22 Dec, 04:18 |
| Mesos Reviewbot Windows |
Re: Review Request 64798: Added an utility to shrink scalar resource while keeping its meta-data. |
Fri, 22 Dec, 05:04 |
| Mesos Reviewbot Windows |
Re: Review Request 64794: Added a test to verify the behavior of allocating resources w/o quota. |
Fri, 22 Dec, 05:32 |
| Alexander Rukletsov |
Re: Review Request 64070: Ensured executor adapter propagates error and shutdown messages. |
Fri, 22 Dec, 11:08 |
| Mesos Reviewbot Windows |
Re: Review Request 64765: Removed a stale TODO in the allocator. |
Fri, 22 Dec, 12:02 |
| Mesos Reviewbot Windows |
Re: Review Request 64798: Added an utility to shrink scalar resource while keeping its meta-data. |
Fri, 22 Dec, 12:04 |
| Benjamin Bannier |
Review Request 64806: Fixed resource provider driver disconnection handling. |
Fri, 22 Dec, 13:36 |
| Benjamin Bannier |
Review Request 64805: Changed 'ConstantEndpointDetector' to have value semantics. |
Fri, 22 Dec, 13:36 |
| Alexander Rukletsov |
Re: Review Request 64686: Fixed the type-punned pointer and strict aliasing issue. |
Fri, 22 Dec, 13:39 |
| Alexander Rukletsov |
Re: Review Request 64686: Fixed the type-punned pointer and strict aliasing issue. |
Fri, 22 Dec, 13:41 |
| Alexander Rukletsov |
Re: Review Request 64686: Fixed the type-punned pointer and strict aliasing issue. |
Fri, 22 Dec, 13:42 |
| Alexander Rukletsov |
Review Request 64807: Removed redundant `struct` prefix in "linux/ns.cpp". |
Fri, 22 Dec, 13:42 |
| Alexander Rukletsov |
Re: Review Request 64685: Improved the comment around the union in ns::clone(). |
Fri, 22 Dec, 13:42 |
| Benjamin Bannier |
Re: Review Request 64807: Removed redundant `struct` prefix in "linux/ns.cpp". |
Fri, 22 Dec, 14:29 |
| Benjamin Bannier |
Re: Review Request 64685: Improved the comment around the union in ns::clone(). |
Fri, 22 Dec, 14:29 |
| Alexander Rukletsov |
Re: Review Request 64807: Removed redundant `struct` prefix in "linux/ns.cpp". |
Fri, 22 Dec, 14:32 |
| Alexander Rukletsov |
Re: Review Request 64685: Improved the comment around the union in ns::clone(). |
Fri, 22 Dec, 14:33 |