| Jeff Coffler |
Re: Review Request 64690: Windows: Removed manual use of `O_BINARY`. |
Tue, 19 Dec, 19:25 |
| Gaston Kleiman |
Re: Review Request 64690: Windows: Removed manual use of `O_BINARY`. |
Tue, 19 Dec, 19:26 |
| Jeff Coffler |
Re: Review Request 64689: Windows: Fixed `os::open()` to always use `O_BINARY`. |
Tue, 19 Dec, 19:27 |
| Jeff Coffler |
Review Request 64720: Upgraded to use cURL v7.57.0 on Windows Platform. |
Tue, 19 Dec, 19:33 |
| Andrew Schwartzmeyer |
Re: Review Request 64720: Upgraded to use cURL v7.57.0 on Windows Platform. |
Tue, 19 Dec, 19:35 |
| Andrew Schwartzmeyer |
Re: Review Request 64720: Upgraded to use cURL v7.57.0 on Windows Platform. |
Tue, 19 Dec, 19:38 |
| Mesos Reviewbot Windows |
Re: Review Request 64701: Windows: Added `/EHsc` to `CMAKE_CXX_FLAGS`. |
Tue, 19 Dec, 20:10 |
| Mesos Reviewbot Windows |
Re: Review Request 64690: Windows: Removed manual use of `O_BINARY`. |
Tue, 19 Dec, 20:13 |
| Mesos Reviewbot Windows |
Re: Review Request 64720: Upgraded to use cURL v7.57.0 on Windows Platform. |
Tue, 19 Dec, 21:12 |
| Joseph Wu |
Re: Review Request 64697: Windows: Deleted unused and unnecessary OS version functions. |
Tue, 19 Dec, 21:28 |
| Mesos Reviewbot Windows |
Re: Review Request 64647: Updated tests related to containerizer refactoring. |
Tue, 19 Dec, 22:14 |
| Chun-Hung Hsiao |
Review Request 64725: Refactred `UriVolumeProfileAdaptor` and `VolumeProfileTest`. |
Tue, 19 Dec, 22:17 |
| Jeff Coffler |
Re: Review Request 64720: Upgraded to use cURL v7.57.0 on Windows Platform. |
Tue, 19 Dec, 22:27 |
| Andrew Schwartzmeyer |
Re: Review Request 64720: Upgraded to use cURL v7.57.0 on Windows Platform. |
Tue, 19 Dec, 22:38 |
| Andrew Schwartzmeyer |
Re: Review Request 64720: Upgraded to use cURL v7.57.0 on Windows Platform. |
Tue, 19 Dec, 22:44 |
| Eric Mumau via Review Board |
Re: Review Request 64701: Windows: Added `/EHsc` to `CMAKE_CXX_FLAGS`. |
Tue, 19 Dec, 22:46 |
| Mesos Reviewbot Windows |
Re: Review Request 64725: Refactored `UriVolumeProfileAdaptor` and `VolumeProfileTest`. |
Tue, 19 Dec, 23:14 |
| Jie Yu |
Re: Review Request 64725: Refactored `UriVolumeProfileAdaptor` and `VolumeProfileTest`. |
Tue, 19 Dec, 23:14 |
| Gaston Kleiman |
Review Request 64726: Renamed operation protos for consistency. |
Wed, 20 Dec, 00:12 |
| Chun-Hung Hsiao |
Review Request 64727: Moved files related to volume profiles into `resource_provider/storage`. |
Wed, 20 Dec, 00:20 |
| Chun-Hung Hsiao |
Re: Review Request 64726: Renamed operation protos for consistency. |
Wed, 20 Dec, 00:27 |
| Chun-Hung Hsiao |
Re: Review Request 64726: Renamed operation protos for consistency. |
Wed, 20 Dec, 00:38 |
| Michael Park |
Review Request 64737: Added validation / normalized resources for storage-related operations. |
Wed, 20 Dec, 00:49 |
| Michael Park |
Review Request 64739: Upgraded resources that come from `protobuf::read`. |
Wed, 20 Dec, 00:51 |
| Michael Park |
Review Request 64738: Pulled out `upgradeResources` out of `validateAndNormalizeResources`. |
Wed, 20 Dec, 00:51 |
| Michael Park |
Review Request 63978: Added tests for protobuf reflection-based `downgradeResources`. |
Wed, 20 Dec, 00:52 |
| Gaston Kleiman |
Re: Review Request 64726: Renamed operation protos for consistency. |
Wed, 20 Dec, 00:57 |
| Mesos Reviewbot Windows |
Re: Review Request 64726: Renamed operation protos for consistency. |
Wed, 20 Dec, 01:08 |
| Jie Yu |
Re: Review Request 64737: Added validation / normalized resources for storage-related operations. |
Wed, 20 Dec, 01:18 |
| Greg Mann |
Re: Review Request 64726: Renamed operation protos for consistency. |
Wed, 20 Dec, 01:38 |
| Benjamin Mahler |
Review Request 64741: Eliminated some unnecessary copying in the HTTP operator API. |
Wed, 20 Dec, 01:47 |
| Mesos Reviewbot Windows |
Re: Review Request 64739: Upgraded resources that come from `protobuf::read`. |
Wed, 20 Dec, 01:58 |
| Mesos Reviewbot Windows |
Re: Review Request 64727: Moved files related to volume profiles into `resource_provider/storage`. |
Wed, 20 Dec, 02:03 |
| Gaston Kleiman |
Re: Review Request 64726: Renamed operation protos for consistency. |
Wed, 20 Dec, 02:05 |
| Meng Zhu |
Re: Review Request 64003: Made quota resource allocation fine-grained. |
Wed, 20 Dec, 02:06 |
| Benjamin Mahler |
Re: Review Request 64737: Added validation / normalized resources for storage-related operations. |
Wed, 20 Dec, 02:09 |
| Mesos Reviewbot Windows |
Re: Review Request 64003: Made quota resource allocation fine-grained. |
Wed, 20 Dec, 02:10 |
| Benjamin Mahler |
Re: Review Request 64738: Pulled out `upgradeResources` out of `validateAndNormalizeResources`. |
Wed, 20 Dec, 02:13 |
| Gaston Kleiman |
Re: Review Request 64726: Renamed operation protos for consistency. |
Wed, 20 Dec, 02:52 |
| Gaston Kleiman |
Re: Review Request 64726: Renamed operation protos for consistency. |
Wed, 20 Dec, 02:53 |
| Mesos Reviewbot Windows |
Re: Review Request 64741: Eliminated some unnecessary copying in the HTTP operator API. |
Wed, 20 Dec, 03:03 |
| Mesos Reviewbot Windows |
Re: Review Request 64726: Renamed operation protos for consistency. |
Wed, 20 Dec, 03:29 |
| Jie Yu |
Review Request 64742: Made volume secret isolator not standalone container aware. |
Wed, 20 Dec, 03:36 |
| Chun-Hung Hsiao |
Re: Review Request 64742: Made volume secret isolator not standalone container aware. |
Wed, 20 Dec, 03:39 |
| Andrew Schwartzmeyer |
Review Request 64729: Made `Duration::operator*` accept `int` and `size_t`. |
Wed, 20 Dec, 03:40 |
| Andrew Schwartzmeyer |
Review Request 64730: Changed `Sorter::count()` to return `size_t` instead of `int`. |
Wed, 20 Dec, 03:40 |
| Andrew Schwartzmeyer |
Review Request 64731: Ended `IOSwitchboard::_prepare` with `UNREACHABLE`. |
Wed, 20 Dec, 03:41 |
| Andrew Schwartzmeyer |
Review Request 64732: Fixed conversion warnings in tests. |
Wed, 20 Dec, 03:41 |
| Andrew Schwartzmeyer |
Review Request 64733: Fixed conversion warnings in tests. |
Wed, 20 Dec, 03:41 |
| Andrew Schwartzmeyer |
Review Request 64734: Fixed conversion warnings. |
Wed, 20 Dec, 03:43 |
| Andrew Schwartzmeyer |
Review Request 64735: Fixed conversion warnings in tests. |
Wed, 20 Dec, 03:43 |
| Andrew Schwartzmeyer |
Review Request 64736: Fixed conversion warnings. |
Wed, 20 Dec, 03:45 |
| James Peach |
Review Request 64743: Enabled function sections. |
Wed, 20 Dec, 03:50 |
| Andrew Schwartzmeyer |
Re: Review Request 64743: Enabled function sections. |
Wed, 20 Dec, 04:08 |
| Mesos Reviewbot Windows |
Re: Review Request 64729: Made `Duration::operator*` accept `int` and `size_t`. |
Wed, 20 Dec, 04:30 |
| Mesos Reviewbot Windows |
Re: Review Request 64742: Made volume secret isolator not standalone container aware. |
Wed, 20 Dec, 04:33 |
| Mesos Reviewbot Windows |
Re: Review Request 64736: Fixed conversion warnings. |
Wed, 20 Dec, 04:40 |
| Mesos Reviewbot Windows |
Re: Review Request 64743: Enabled function sections. |
Wed, 20 Dec, 05:30 |
| Benjamin Bannier |
Re: Review Request 64743: Enabled function sections. |
Wed, 20 Dec, 10:52 |
| Alexander Rukletsov |
Re: Review Request 64450: Update docs to mention new '--reconfiguration_policy' flag. |
Wed, 20 Dec, 11:27 |
| Alexander Rukletsov |
Re: Review Request 64069: Ensured command executor always honors shutdown request. |
Wed, 20 Dec, 11:54 |
| Alexander Rukletsov |
Re: Review Request 64069: Ensured command executor always honors shutdown request. |
Wed, 20 Dec, 12:02 |
| Jan Schlicht |
Re: Review Request 64713: Fixed a crash when resubscribing resource providers. |
Wed, 20 Dec, 13:24 |
| Benno Evers |
Re: Review Request 64450: Update docs to mention new flag. |
Wed, 20 Dec, 13:26 |
| Jan Schlicht |
Re: Review Request 64713: Fixed a crash when resubscribing resource providers. |
Wed, 20 Dec, 13:38 |
| Benno Evers |
Re: Review Request 64450: Update docs to mention new flag. |
Wed, 20 Dec, 13:40 |
| Alexander Rukletsov |
Re: Review Request 64450: Update docs to mention new flag. |
Wed, 20 Dec, 13:48 |
| Andrei Budnik |
Review Request 64749: Fixed flaky `NestedMesosContainerizerTest` tests. |
Wed, 20 Dec, 13:50 |
| Alexander Rukletsov |
Re: Review Request 64749: Fixed flaky `NestedMesosContainerizerTest` tests. |
Wed, 20 Dec, 13:55 |
| Andrei Budnik |
Re: Review Request 64749: Fixed flaky `NestedMesosContainerizerTest` tests. |
Wed, 20 Dec, 13:59 |
| Benno Evers |
Re: Review Request 64450: Update docs to mention new flag. |
Wed, 20 Dec, 14:11 |
| Mesos Reviewbot Windows |
Re: Review Request 64450: Update docs to mention new flag. |
Wed, 20 Dec, 14:19 |
| Benjamin Bannier |
Review Request 64750: Fixed an agent assertion. |
Wed, 20 Dec, 14:22 |
| Mesos Reviewbot Windows |
Re: Review Request 64713: Fixed a crash when resubscribing resource providers. |
Wed, 20 Dec, 14:22 |
| Mesos Reviewbot Windows |
Re: Review Request 64750: Fixed an agent assertion. |
Wed, 20 Dec, 15:22 |
| Alexander Rukletsov |
Re: Review Request 64069: Ensured command executor always honors shutdown request. |
Wed, 20 Dec, 16:02 |
| Jie Yu |
Re: Review Request 64750: Fixed an agent assertion. |
Wed, 20 Dec, 16:05 |
| Alexander Rukletsov |
Re: Review Request 64069: Ensured command executor always honors shutdown request. |
Wed, 20 Dec, 16:07 |
| Alexander Rukletsov |
Re: Review Request 64070: Ensured executor adapter propagates error and shutdown messages. |
Wed, 20 Dec, 16:12 |
| Alexander Rukletsov |
Re: Review Request 64033: Terminated driver-based executors if kill arrives before launch task. |
Wed, 20 Dec, 16:27 |
| Alexander Rukletsov |
Re: Review Request 64070: Ensured executor adapter propagates error and shutdown messages. |
Wed, 20 Dec, 16:27 |
| Alexander Rukletsov |
Re: Review Request 64070: WIP: Ensured executor adapter propagates error and shutdown messages. |
Wed, 20 Dec, 16:27 |
| Mesos Reviewbot Windows |
Re: Review Request 64069: Ensured command executor always honors shutdown request. |
Wed, 20 Dec, 17:12 |
| Jie Yu |
Re: Review Request 64726: Renamed operation protos for consistency. |
Wed, 20 Dec, 18:05 |
| Mesos Reviewbot Windows |
Re: Review Request 64070: WIP: Ensured executor adapter propagates error and shutdown messages. |
Wed, 20 Dec, 18:10 |
| Mesos Reviewbot Windows |
Re: Review Request 64033: Terminated driver-based executors if kill arrives before launch task. |
Wed, 20 Dec, 18:12 |
| Gaston Kleiman |
Re: Review Request 64726: Renamed operation protos for consistency. |
Wed, 20 Dec, 19:21 |
| Jie Yu |
Re: Review Request 64726: Renamed operation protos for consistency. |
Wed, 20 Dec, 19:27 |
| Greg Mann |
Re: Review Request 64726: Renamed operation protos for consistency. |
Wed, 20 Dec, 19:41 |
| Mesos Reviewbot Windows |
Re: Review Request 64726: Renamed operation protos for consistency. |
Wed, 20 Dec, 19:49 |
| Meng Zhu |
Re: Review Request 64741: Eliminated some unnecessary copying in the HTTP operator API. |
Wed, 20 Dec, 19:52 |
| Alexander Rukletsov |
Re: Review Request 64032: Promoted log level to warning for disconnected events in exec.cpp. |
Wed, 20 Dec, 20:14 |
| Alexander Rukletsov |
Re: Review Request 64069: Ensured command executor always honors shutdown request. |
Wed, 20 Dec, 20:14 |
| Alexander Rukletsov |
Re: Review Request 64070: Ensured executor adapter propagates error and shutdown messages. |
Wed, 20 Dec, 20:16 |
| Alexander Rukletsov |
Re: Review Request 64033: Terminated driver-based executors if kill arrives before launch task. |
Wed, 20 Dec, 20:17 |
| Alexander Rukletsov |
Re: Review Request 64033: Terminated driver-based executors if kill arrives before launch task. |
Wed, 20 Dec, 20:35 |
| Mesos Reviewbot Windows |
Re: Review Request 64033: Terminated driver-based executors if kill arrives before launch task. |
Wed, 20 Dec, 21:13 |
| Chun-Hung Hsiao |
Re: Review Request 64590: Stopped logging optional fields unconditionally in agent handler. |
Wed, 20 Dec, 21:52 |
| Meng Zhu |
Review Request 64758: Added a test to ensure MOUNT disk resource is allocated exclusively. |
Wed, 20 Dec, 22:07 |
| Mesos Reviewbot Windows |
Re: Review Request 64758: Added a test to ensure MOUNT disk resource is allocated exclusively. |
Wed, 20 Dec, 22:10 |