mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Review Request 64879: Updated fetcher cache tests for the default executor.
Date Sat, 30 Dec 2017 20:06:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64879/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Anand Mazumdar, and Jie Yu.


Bugs: MESOS-8366
    https://issues.apache.org/jira/browse/MESOS-8366


Repository: mesos


Description
-------

Updated the task launch helper to obtain the ContainerID of the
launched task, which can be used to correctly construct the sandbox
path for both the command and default executors.

Updated the test expectations in cases where the default executor
container will invoke the fetcher more times than the test is
expecting.

Updated various test helper functions to propagate more detailed
error results that make test failure easier to debug.


Diffs
-----

  src/tests/fetcher_cache_tests.cpp 7db7b7dcef27b1686ccae5a7408ff2811a3b9255 


Diff: https://reviews.apache.org/r/64879/diff/1/


Testing
-------

make check (Fedora 27)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message