mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gaston Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 64590: Stopped logging optional fields unconditionally in agent handler.
Date Thu, 28 Dec 2017 20:21:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64590/
-----------------------------------------------------------

(Updated Dec. 28, 2017, 12:21 p.m.)


Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu.


Changes
-------

Addressed feedback, rebased.


Repository: mesos


Description
-------

The `operation_id` and `framework_id` fields are optional, so they
should only be logged if set.


Diffs (updated)
-----

  src/slave/slave.cpp e0806ab15be3ea790681dc97b20791c8a20512e3 


Diff: https://reviews.apache.org/r/64590/diff/5/

Changes: https://reviews.apache.org/r/64590/diff/4-5/


Testing
-------

`make check` on GNU/Linux


Thanks,

Gaston Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message