mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 64738: Pulled out `upgradeResources` out of `validateAndNormalizeResources`.
Date Thu, 28 Dec 2017 04:50:25 GMT


> On Dec. 19, 2017, 6:13 p.m., Benjamin Mahler wrote:
> > The "upgrade" vs "normalize" inconsistency seems a little odd?

I'll follow up with a patch to change "normalize" to "upgrade".
Seems more fitting with the presence of "downgrade".


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64738/#review194205
-----------------------------------------------------------


On Dec. 19, 2017, 4:51 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64738/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2017, 4:51 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/common/resources_utils.cpp 1676b72a9ad15bf8b131698a0600a1b0937c00b4 
> 
> 
> Diff: https://reviews.apache.org/r/64738/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message