mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Review Request 64856: Fixed resource provider driver disconnection handling.
Date Wed, 27 Dec 2017 17:13:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64856/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier and Jan Schlicht.


Bugs: MESOS-8349
    https://issues.apache.org/jira/browse/MESOS-8349


Repository: mesos


Description
-------

The expectation for disconnection of the resource provider driver is
that disconnection handlers of the resource provider would be invoked
and a new connection would be detected.

This patch fixed the issue by transition the future returned by
ConstantEndpointDetector into DISCARDED if a "discard" is initiated by
the caller. This will properly trigger `detected` callback to be called.

This patch is based on: https://reviews.apache.org/r/64806/


Diffs
-----

  src/resource_provider/detector.cpp 59f2b9b7910cfb7fff9940a31b5f57c87b9b0602 
  src/resource_provider/http_connection.hpp 3d5088dc1eeeb64a932a731d10e4c12564e79034 
  src/tests/resource_provider_manager_tests.cpp f58ab6b4c98eff92ae23acacefbcb9066b5ace91 


Diff: https://reviews.apache.org/r/64856/diff/1/


Testing
-------

make check


Thanks,

Jie Yu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message