mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhitao Li <zhitaoli...@gmail.com>
Subject Re: Review Request 64812: Added `excluded_images` parameter to `PRUNE_IMAGES` agent API.
Date Tue, 26 Dec 2017 16:52:34 GMT


> On Dec. 26, 2017, 4:06 p.m., Gilbert Song wrote:
> > src/slave/http.cpp
> > Line 2450 (original), 2450-2459 (patched)
> > <https://reviews.apache.org/r/64812/diff/2/?file=1927543#file1927543line2450>
> >
> >     see my comment at https://reviews.apache.org/r/56722/
> >     
> >     excluded images from the operator API might be neglected due to another auto-triggered
GC.

IMO the content of this API was not inteded to be persisted. Even consecutive calls with different
`excluded_images` can have similar effect of what you described and there is nothing we can
or should do. If operator enabled auto gc, then the list should be maintained or duplicated
there.


- Zhitao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64812/#review194515
-----------------------------------------------------------


On Dec. 24, 2017, 1:21 a.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64812/
> -----------------------------------------------------------
> 
> (Updated Dec. 24, 2017, 1:21 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-4945
>     https://issues.apache.org/jira/browse/MESOS-4945
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added `excluded_images` parameter to `PRUNE_IMAGES` agent API.
> 
> 
> Diffs
> -----
> 
>   include/mesos/agent/agent.proto 25af6dc64ca35126fd70dd10388bd2cea6dcbd36 
>   include/mesos/v1/agent/agent.proto 4ae9013e6fb27bdce72b4aa9fc9cbd99f79bc548 
>   src/slave/http.cpp 3e20c90fb94f0128a757745052534ef03612d849 
> 
> 
> Diff: https://reviews.apache.org/r/64812/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message