mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 64793: Fixed a bug where resource over allocation may break quota headroom.
Date Fri, 22 Dec 2017 23:14:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64793/#review194463
-----------------------------------------------------------


Fix it, then Ship it!




Hm.. technically the reservation might not be "making progress towards quota" if it does not
involve any quota resources. I'll clarify that in the comments / description.


src/master/allocator/mesos/hierarchical.cpp
Line 1930 (original), 1946-1948 (patched)
<https://reviews.apache.org/r/64793/#comment273233>

    Looks like this being guarded by `if (!unsatisfiedQuota.empty()) {` prevents this from
adding the resources when just reservation(s) are being allocated, contrary to the comments?


- Benjamin Mahler


On Dec. 22, 2017, 4:17 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64793/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2017, 4:17 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-8352
>     https://issues.apache.org/jira/browse/MESOS-8352
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In the quota role allocation stage, if a role gets some resources
> on an agent to meet its quota, it will also get all other resources
> on the same agent that it does not have quota for. This may starve
> roles behind it that have quotas set for those resources.
> 
> We fix this issue by enforcing that, in the quota role allocation
> stage, if a role has no quota set for a scalar resource, it will
> get that resource only when two conditions are both met:
> 
> (1) It got some other resources on the same agent to meet its quota;
> 
> (2) After allocating those resources, quota headroom is still above
> the required amount.
> 
> Also refactored the fine-grained quota allocation logic.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 78d7b2203532301ff26b7abb26f5d320831124a1

> 
> 
> Diff: https://reviews.apache.org/r/64793/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message