mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 64811: Cleaned up ContainerInfo generation logic in the slave.
Date Fri, 22 Dec 2017 20:44:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64811/#review194457
-----------------------------------------------------------



PASS: Mesos patch 64811 was successfully built and tested.

Reviews applied: `['63598', '64811']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64811

- Mesos Reviewbot Windows


On Dec. 22, 2017, 7:47 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64811/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2017, 7:47 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gilbert Song, and Julien Pepy.
> 
> 
> Bugs: MESOS-7007
>     https://issues.apache.org/jira/browse/MESOS-7007
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> After this patch, the invariant becomes that for command tasks, we
> always set the ContainerInfo of the generated ExecutorInfo to be the
> same as that in TaskInfo (if exists). This simplifies the logic when we
> actually generate ContainerInfo for containerizer during launching
> phase.
> 
> This also made the logic introduced in the following patch more readable
> and maintainable: https://reviews.apache.org/r/63598
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 47d5632115bbfd2b729dc2388c01733f907cf938 
> 
> 
> Diff: https://reviews.apache.org/r/64811/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message