mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 63598: Set container info from executor by default if available.
Date Fri, 22 Dec 2017 19:53:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63598/#review194455
-----------------------------------------------------------


Ship it!




Ship It!

- Chun-Hung Hsiao


On Nov. 8, 2017, 1:03 a.m., Julien Pepy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63598/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2017, 1:03 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-7007
>     https://issues.apache.org/jira/browse/MESOS-7007
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The current implementation only works for non-command executor
> instances. We still need to get the container info from the executor
> (if none has been defined in the task) in command mode to properly use
> some features (volumes for example).
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp c10823985154bac19f8952b94311a03b2b9b4ea1 
> 
> 
> Diff: https://reviews.apache.org/r/63598/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> Tested manually with a single task on an agent configured with `--default_container_info='{"type":"MESOS","volumes":[{"host_path":"tmp","container_path":"/tmp","mode":"RW"}]}'`:
> ```
> sudo -u hello mesos-execute --master='localhost:5050' --name=test --command="echo hello
>/tmp/test; df -hT /tmp" | tee ~/test.log
> framework_id=$(cat ~/test.log | grep Subscribed | awk '{print $4}')
> ls -l /var/opt/mesos/slaves/*/frameworks/$framework_id/executors/test/runs/latest/tmp
> ```
> 
> Result output:
> ```
> Filesystem     Type  Size  Used Avail Use% Mounted on
> /dev/sda3      ext4   37G  7.3G   28G  21% /tmp
> total 4
> -rw-r--r--. 1 hello users 6  6 nov.  15:21 test
> ```
> 
> 
> Thanks,
> 
> Julien Pepy
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message