mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 64685: Improved the comment around the union in ns::clone().
Date Fri, 22 Dec 2017 14:33:18 GMT


> On Dec. 22, 2017, 2:29 p.m., Benjamin Bannier wrote:
> > src/linux/ns.cpp
> > Line 320 (original), 320 (patched)
> > <https://reviews.apache.org/r/64685/diff/2/?file=1926496#file1926496line320>
> >
> >     Since you are at it, could you make the first part a full sentence, e.g.,
> >     
> >     > _We_ need ...

Sure!


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64685/#review194427
-----------------------------------------------------------


On Dec. 22, 2017, 1:42 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64685/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2017, 1:42 p.m.)
> 
> 
> Review request for mesos, Armand Grillet, Benjamin Bannier, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/linux/ns.cpp 5e2df1ed56432c6c1bfa04a31dba7f9f547d6139 
> 
> 
> Diff: https://reviews.apache.org/r/64685/diff/2/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/64686/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message