mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 64807: Removed redundant `struct` prefix in "linux/ns.cpp".
Date Fri, 22 Dec 2017 14:32:31 GMT


> On Dec. 22, 2017, 2:29 p.m., Benjamin Bannier wrote:
> > src/linux/ns.cpp
> > Line 184 (original), 184 (patched)
> > <https://reviews.apache.org/r/64807/diff/1/?file=1926498#file1926498line184>
> >
> >     Kill this `struct` as well?

Not sure we can do this. There is also `stat()` POSIX function.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64807/#review194428
-----------------------------------------------------------


On Dec. 22, 2017, 1:42 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64807/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2017, 1:42 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/linux/ns.cpp 5e2df1ed56432c6c1bfa04a31dba7f9f547d6139 
> 
> 
> Diff: https://reviews.apache.org/r/64807/diff/1/
> 
> 
> Testing
> -------
> 
> make check on various Linux distros
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message