mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 64686: Fixed the type-punned pointer and strict aliasing issue.
Date Fri, 22 Dec 2017 13:42:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64686/
-----------------------------------------------------------

(Updated Dec. 22, 2017, 1:42 p.m.)


Review request for mesos, Armand Grillet, Benjamin Bannier, and Michael Park.


Bugs: MESOS-6616
    https://issues.apache.org/jira/browse/MESOS-6616


Repository: mesos


Description
-------

Dereferencing a pointer cast from a different type of pointer
violates the so-called “strict aliasing” rule, which is undefined
behaviour and might lead to bugs when compiler optimizations are
enabled.

For more information on this topic, see
https://blog.regehr.org/archives/959
http://alas.matf.bg.ac.rs/manuals/lspe/snode=153.html


Diffs (updated)
-----

  src/linux/ns.cpp 5e2df1ed56432c6c1bfa04a31dba7f9f547d6139 


Diff: https://reviews.apache.org/r/64686/diff/3/

Changes: https://reviews.apache.org/r/64686/diff/2-3/


Testing
-------

make check on Mac OS 10.11.6 and various Linux distros


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message