mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 64805: Changed 'ConstantEndpointDetector' to have value semantics.
Date Fri, 22 Dec 2017 13:36:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64805/
-----------------------------------------------------------

Review request for mesos, Jie Yu and Jan Schlicht.


Repository: mesos


Description
-------

The class 'ConstantEndpointDetector' was holding a reference to one of
its constructor parameters which introduces unnecessary brittleness.

In this patch we adjust the class to just hold a copy of the
originally passed value instead.


Diffs
-----

  src/resource_provider/detector.hpp 68ea8cf2de4f2decc3eede16cf59fa8a851502f4 


Diff: https://reviews.apache.org/r/64805/diff/1/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message