mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 64794: Added a test to verify the behavior of allocating resources w/o quota.
Date Fri, 22 Dec 2017 02:52:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64794/#review194395
-----------------------------------------------------------


Fix it, then Ship it!




Nice test! Just some minor suggestions below and what looks like an inaccurate comment?


src/tests/hierarchical_allocator_tests.cpp
Lines 3495 (patched)
<https://reviews.apache.org/r/64794/#comment273155>

    a resource?



src/tests/hierarchical_allocator_tests.cpp
Lines 3501 (patched)
<https://reviews.apache.org/r/64794/#comment273157>

    Maybe: It was allocated quota resources on the agent



src/tests/hierarchical_allocator_tests.cpp
Lines 3503-3504 (patched)
<https://reviews.apache.org/r/64794/#comment273156>

    Maybe: It can be allocated without violating the quota headroom



src/tests/hierarchical_allocator_tests.cpp
Lines 3505 (patched)
<https://reviews.apache.org/r/64794/#comment273158>

    QuotaRoleAllocateNonQuotaResource?



src/tests/hierarchical_allocator_tests.cpp
Lines 3581 (patched)
<https://reviews.apache.org/r/64794/#comment273159>

    Shouldn't memory be absent here?


- Benjamin Mahler


On Dec. 22, 2017, 12:48 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64794/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2017, 12:48 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-8352
>     https://issues.apache.org/jira/browse/MESOS-8352
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test verifies the behavior of allocating resource to quota roles
> that has no quota set for that particular resource (e.g. allocating
> memory to a role with only quota set for CPU). If a role has no quota
> set for a resource, it will get that resource only when two conditions
> are both met:
> 
> - It got some other resources on the same agent to meet its quota;
> 
> - After allocating the resource, there is still enough resource
> available to meet all other role's quota guarantee for that resource.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp ad9d556f040b2b51b6c43757f8bad05d61a057e7

> 
> 
> Diff: https://reviews.apache.org/r/64794/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message