mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Review Request 64793: Fixed a bug where resource over allocation may break quota headroom.
Date Fri, 22 Dec 2017 00:48:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64793/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-8352
    https://issues.apache.org/jira/browse/MESOS-8352


Repository: mesos


Description
-------

In the quota role allocation stage, if a role gets some resources
on an agent to meet its quota, it will also get all other resources
on the same agent that it does not have quota for. This may starve
roles behind it that have quotas set for those resources.

We fix this issue by enforcing that, in the quota role allocation
stage, if a role has no quota set for a scalar resource, it will
get that resource only when two conditions are both met:

(1) It got some other resources on the same agent to meet its quota;

(2) After allocating those resources, quota headroom is still above
the required amount.

Also refactored the fine-grained quota allocation logic.


Diffs
-----

  src/master/allocator/mesos/hierarchical.cpp 7f7dae1950bebd22191189c2db0f6678d2e8fa3c 


Diff: https://reviews.apache.org/r/64793/diff/1/


Testing
-------

make check


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message