mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 62286: Added CatchupMissing log process.
Date Thu, 21 Dec 2017 22:17:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62286/#review194370
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Oct. 3, 2017, 11:16 p.m., Ilya Pronin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62286/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2017, 11:16 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-7973
>     https://issues.apache.org/jira/browse/MESOS-7973
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The process is used to catch-up a non-leading VOTING replica by running
> the recovery protocol to find current begin and end positions of the log
> and catching-up positions that are missing on the replica. This allows
> following replicas to serve eventually consistent reads.
> 
> 
> Diffs
> -----
> 
>   src/log/catchup.hpp 123bc7a57e5e89f9ba75c36ba0cbe5ead807c518 
>   src/log/catchup.cpp 94e1b00db2cd9d5a2368a979c1fd155bb6cac1f2 
>   src/tests/log_tests.cpp f9f9400c901152779ae0ebfe74cf8f7aac1d3396 
> 
> 
> Diff: https://reviews.apache.org/r/62286/diff/2/
> 
> 
> Testing
> -------
> 
> Added tests that verify that the new recovery process correctly performs and produces
meaningful result under various circumstances (recovered positions were truncated, replica
was lagging far behind). Ran `make check`.
> 
> 
> Thanks,
> 
> Ilya Pronin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message