mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 64755: Removed the usage of `Bytes::kilobytes()` and `Bytes::megabytes()`.
Date Thu, 21 Dec 2017 19:01:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64755/
-----------------------------------------------------------

(Updated Dec. 21, 2017, 7:01 p.m.)


Review request for mesos, Benjamin Bannier, Benjamin Mahler, Jie Yu, and Vinod Kone.


Changes
-------

Addressed Jie's comments.


Repository: mesos


Description
-------

Removed the usage of `Bytes::kilobytes()` and `Bytes::megabytes()`.


Diffs (updated)
-----

  src/examples/balloon_executor.cpp 7343ee72c1fc8d6e58527809ffb74fc5dd09ee0e 
  src/examples/balloon_framework.cpp a36e04b033ba66ba911abde2ad3d6f58decae18a 
  src/examples/disk_full_framework.cpp d9d2d3513529f3a19f392b314001930746d5c91d 
  src/master/validation.cpp 1e1e75447b6ed12566bf66fced23606a0f2f6a15 
  src/resource_provider/storage/provider.cpp b6781d6ebddb00351dde28454d34b5fab6f36453 
  src/slave/containerizer/containerizer.cpp 935dfc9ea787ae714a86c7bc54811703c23267c8 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp 113e908743b718e7ad645e8e08b481ed97a4021f

  src/slave/slave.cpp e091d822acf6b607c2bb265bd5e4011da145952a 
  src/tests/container_logger_tests.cpp b65cf6a9096dfaa418fd7eb400771cc6df642ea2 
  src/tests/containerizer/docker_containerizer_tests.cpp 630bb2e352dd55ecb401730c84f823e0a1f2d310

  src/tests/hierarchical_allocator_tests.cpp c98bebb36f27480d4f21eb85ad9b1c27de8b9e82 
  src/tests/mesos.hpp 5e833a1e23bfba5cbc58f77bfcd6cd4e4647a99e 
  src/tests/persistent_volume_tests.cpp 5962dd13e49c515fffdd62cc4883ba224e421a06 


Diff: https://reviews.apache.org/r/64755/diff/3/

Changes: https://reviews.apache.org/r/64755/diff/2-3/


Testing
-------

sudo make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message