mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 64754: Removed `kilobytes()`, `megabytes()`, etc from `Bytes`.
Date Thu, 21 Dec 2017 16:31:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64754/#review194346
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/stout/include/stout/bytes.hpp
Lines 145 (patched)
<https://reviews.apache.org/r/64754/#comment273109>

    Do you need this?


- Jie Yu


On Dec. 21, 2017, 3:41 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64754/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2017, 3:41 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These functios are removed because they are lossy. The unit conversion
> for `Resource` should be explicit. For example:
>   `resource.scalar().set_value((double) size.bytes() / Bytes::MEGABYTES)`
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/bytes.hpp cbe953662bb86c2f1eef3453f557ea17c0c6d13e 
> 
> 
> Diff: https://reviews.apache.org/r/64754/diff/2/
> 
> 
> Testing
> -------
> 
> See later in chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message