mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 64647: Updated tests related to containerizer refactoring.
Date Thu, 21 Dec 2017 14:03:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64647/#review194331
-----------------------------------------------------------



PASS: Mesos patch 64647 was successfully built and tested.

Reviews applied: `['64646', '64647']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64647

- Mesos Reviewbot Windows


On Dec. 15, 2017, 11:41 a.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64647/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2017, 11:41 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch is needed due to changes in Containerizer interface,
> where `wait()`, `destroy()` and `kill()` methods return the same
> ContainerTermination type.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer.hpp d6a69d6327018065453f8a6cb275d921d10c9198 
>   src/tests/containerizer.cpp 13a290ff60e359ceced95b20cb9db8c25cd59dbc 
>   src/tests/containerizer/composing_containerizer_tests.cpp 7c22f162b128c3fdf8d4b20cac73fdf442449d79

>   src/tests/containerizer/docker_containerizer_tests.cpp 630bb2e352dd55ecb401730c84f823e0a1f2d310

>   src/tests/containerizer/io_switchboard_tests.cpp f217d02bba2d1372392ad4da521940d27e4f69d4

>   src/tests/containerizer/mesos_containerizer_tests.cpp 0729464a7a9b290c8634536e58909f9b38b58a9c

>   src/tests/containerizer/mock_containerizer.hpp 01c617a55899a7125ca1dc80091aef5603419ee8

> 
> 
> Diff: https://reviews.apache.org/r/64647/diff/3/
> 
> 
> Testing
> -------
> 
> make check (fedora 25)
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message