mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 64755: Removed the usage of `Bytes::kilobytes()` and `Bytes::megabytes()`.
Date Thu, 21 Dec 2017 03:41:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64755/
-----------------------------------------------------------

(Updated Dec. 21, 2017, 3:41 a.m.)


Review request for mesos, Benjamin Bannier, Benjamin Mahler, Jie Yu, and Vinod Kone.


Changes
-------

Removed all calls to the `Bytes` helpers.


Summary (updated)
-----------------

Removed the usage of `Bytes::kilobytes()` and `Bytes::megabytes()`.


Repository: mesos


Description (updated)
-------

Removed the usage of `Bytes::kilobytes()` and `Bytes::megabytes()`.


Diffs (updated)
-----

  src/examples/balloon_executor.cpp 7343ee72c1fc8d6e58527809ffb74fc5dd09ee0e 
  src/examples/balloon_framework.cpp a36e04b033ba66ba911abde2ad3d6f58decae18a 
  src/examples/disk_full_framework.cpp d9d2d3513529f3a19f392b314001930746d5c91d 
  src/master/validation.cpp 7f5a67d98dbbd5a5d64bc73d530f3d37b3cdfec6 
  src/resource_provider/storage/provider.cpp 833d929e93afd0bb99a9574df24168e82269bc81 
  src/slave/containerizer/containerizer.cpp 935dfc9ea787ae714a86c7bc54811703c23267c8 
  src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp 113e908743b718e7ad645e8e08b481ed97a4021f

  src/slave/slave.cpp 6271cfe56733ec121d0d7c691e3dd0792435bf2d 
  src/tests/container_logger_tests.cpp b65cf6a9096dfaa418fd7eb400771cc6df642ea2 
  src/tests/containerizer/docker_containerizer_tests.cpp 630bb2e352dd55ecb401730c84f823e0a1f2d310

  src/tests/hierarchical_allocator_tests.cpp 173e4fbac184ad8d40c8adba19ad64225f11f1f2 
  src/tests/mesos.hpp 41f47cf1b10fddd51e260e2127e2695ffe1aeba5 
  src/tests/persistent_volume_tests.cpp 854676918dba497e1a8c21d877631c6e5c75ee2e 


Diff: https://reviews.apache.org/r/64755/diff/2/

Changes: https://reviews.apache.org/r/64755/diff/1-2/


Testing
-------

sudo make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message