mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 64741: Eliminated some unnecessary copying in the HTTP operator API.
Date Thu, 21 Dec 2017 01:33:05 GMT


> On Dec. 20, 2017, 7:52 p.m., Meng Zhu wrote:
> > src/master/http.cpp
> > Lines 4232-4235 (original), 4232-4234 (patched)
> > <https://reviews.apache.org/r/64741/diff/1/?file=1924196#file1924196line4234>
> >
> >     how about:
> >     
> >     `*getTasks.add_pending_tasks() = protobuf::createTask(taskInfo, TASK_STAGING,
framework->id());`

Sounds good!


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64741/#review194269
-----------------------------------------------------------


On Dec. 20, 2017, 1:47 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64741/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2017, 1:47 a.m.)
> 
> 
> Review request for mesos, Michael Park and Meng Zhu.
> 
> 
> Bugs: MESOS-8344
>     https://issues.apache.org/jira/browse/MESOS-8344
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is only a minor portion of the performance improvements
> needed to bring the v1 operator API close to the v0 API
> performance.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp ec170a257c2d309712f3c4b2fce756eb0b530ad6 
> 
> 
> Diff: https://reviews.apache.org/r/64741/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message